Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly mark @covers annotations in unit tests #15741

Closed
mbabker opened this issue May 2, 2017 · 3 comments
Closed

Explicitly mark @covers annotations in unit tests #15741

mbabker opened this issue May 2, 2017 · 3 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented May 2, 2017

A lot of our test coverage is coming from the fact that there are a lot of deep rooted internal couplings and static method calls which cannot be mocked. This is massively throwing off our coverage reports and misrepresenting our actual state of the test suite. We need to work through the test suite to explicitly mark what the test cases are actually covering so we stop having leakage of covered code through test cases that aren't designed to be covering certain methods (i.e. JApplicationCmsTest shouldn't be covering the JDate constructor). This will help to better represent what we have explicit test cases and coverage for and therefore help us to better refine our test suite.

https://twitter.com/mbabker/status/859412612471300096

@PhilETaylor

This comment was marked as abuse.

@mbabker
Copy link
Contributor Author

mbabker commented May 2, 2017

We've gotta start somewhere. When you have 1900 cases for the JDate constructor and 1896 of them are from tests that cover code that uses JDate (as in they shouldn't be covering that), you're basically left with not knowing what code you're actually testing.

@mbabker
Copy link
Contributor Author

mbabker commented Apr 3, 2018

Most tests are gone in 4.0. No point in touching 3.x tests.

@mbabker mbabker closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants