Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #15743

Closed
wants to merge 2 commits into from
Closed

Code cleanup #15743

wants to merge 2 commits into from

Conversation

demis-palma
Copy link
Contributor

The PHPdoc declares the variable as "double"
@param double $startTime
but the method initialises its default value with an "integer" instead
$startTime = 0

Summary of Changes

Changed the default value to type double

Testing Instructions

To be merged on review

@ghost ghost added the J3 Issue label Apr 5, 2019
@ghost ghost removed the J3 Issue label Apr 19, 2019
@Quy
Copy link
Contributor

Quy commented May 10, 2019

Tested with 0 and 0.0 and the result is always 0. Thus, it doesn't make a difference. Close PR?

$startTime = 0;
echo (double) $startTime; 

@ghost
Copy link

ghost commented May 11, 2019

closed for Reason stated above. Pull Request can always reopened if needed.

@ghost ghost closed this May 11, 2019
@HLeithner
Copy link
Member

There is a difference, the var gets initialized as float if 0.0 so this pr is correct

@HLeithner HLeithner reopened this May 12, 2019
@HLeithner
Copy link
Member

The file moved to libraries/src/Profiler/Profiler.php in the meantime may @demis-palma could rebase it?

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/15743

@Quy
Copy link
Contributor

Quy commented May 21, 2019

Closing in favor of PR #24971


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15743.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants