Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Editing a module on the frontend in the default template issues #15764

Closed
PhilETaylor opened this issue May 3, 2017 · 9 comments
Closed

Comments

@PhilETaylor
Copy link
Contributor

PhilETaylor commented May 3, 2017

Steps to reproduce the issue

Login to frontend
attempt to edit a module

Expected result

Something looking good.

Actual result

screen shot 2017-05-03 at 13 03 19

Additional comments

Also note how the edit form gets "lost" in all the business of all the modules... maybe the edit page should hide much of the page ?

@C-Lodder
Copy link
Member

C-Lodder commented May 3, 2017

Agreed. Should definitely be made easier to find the form. Probably wouldn't be as much of an issue on live/finished sites but with sample data, it's annoying having to scroll down.

  • Option 1: Use JS to scroll the user to the form
  • Option 2: Hide all modules

If option 2 is prefered, is there some fancy Joomla function for this?

@dgrammatiko
Copy link
Contributor

The frontediting.js is not yet compatible with J4

@PhilETaylor

This comment was marked as abuse.

@C-Lodder
Copy link
Member

C-Lodder commented May 3, 2017

That could work too. Would mean the user's ettention is focused purely on the form.

Here's the styling part fixed anyway: #15803

@brianteeman
Copy link
Contributor

@dgrammatiko has frontediting.js been updated yet?

@dgrammatiko
Copy link
Contributor

The status is:

  • frontediting.js has been moved to media/legacy with an intention to have it replaced by a custom element

But this issue reported here seems that has already been solved (?):
screen shot 2018-05-22 at 23 59 08

The proposal for a modal or different UI is something that the @coolcat-creations needs to figure out

@ghost
Copy link

ghost commented May 23, 2018

@PhilETaylor can you please check if the Issues is solved?

@PhilETaylor

This comment was marked as abuse.

@ghost
Copy link

ghost commented May 23, 2018

thanks @PhilETaylor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants