-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing input filter to tags #15950
Conversation
I have tested this item ✅ successfully on 0aa358b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15950. |
does this mean that all uses of 'integer' need to be changed to 'int' ?? |
Actually, no... https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filter/input.php#L150-L151 |
Now I am more confused why it is being changed here. Guess I have lots to learn |
I have changed it based on the doc block: https://github.com/joomla/joomla-cms/blob/staging/libraries/joomla/filter/input.php#L116 As Michael pointed we don't need to change that but we should be consistend there i think. |
Then you're not on the right Joomla version. That file most assuredly exists in 3.7 (staging), with the namespacing effort it doesn't exist in 3.8. |
Always test on staging unless it says it is for a different version |
I have tested this item ✅ successfully on 0aa358b Using PR and search for Tag "red" got: This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15950. |
RTC after two successful tests. |
Summary of Changes
Missing input filter to tags. cc @dgt41
Testing Instructions
Apply this patch and confirm you can still can use the frontend tags seach
Expected result
Still works
Actual result
Works but without input filter
Documentation Changes Required
None