Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codestlye] xml site non components #15952

Merged
merged 4 commits into from
May 23, 2017

Conversation

brianteeman
Copy link
Contributor

codestyle changes for the files not included in the other PR

@wojsmol
Copy link
Contributor

wojsmol commented May 10, 2017

I have tested this item ✅ successfully on 4967ac2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15952.

@@ -22,10 +22,10 @@
<field
name="mode"
type="list"
default="1"
description="PLG_CONTENT_EMAILCLOAK_MODE_DESC"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Swap lines

@tonypartridge
Copy link
Contributor

I have tested this item ✅ successfully on 390fea5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/15952.

@ghost
Copy link

ghost commented May 23, 2017

@wojsmol can you please retest?

label="MOD_POPULAR_FIELD_COUNT_LABEL"
description="MOD_POPULAR_FIELD_COUNT_DESC"
default="5"
/>

<field
Copy link
Contributor

@wojsmol wojsmol May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent
check line 111

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and lines 46 and 128

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@brianteeman ping just in case these have not been fixed in another pr.

@rdeutz
Copy link
Contributor

rdeutz commented May 23, 2017

merged on review

@rdeutz rdeutz merged commit d115fe7 into joomla:staging May 23, 2017
@brianteeman
Copy link
Contributor Author

thanks

@brianteeman brianteeman deleted the xml-site_non_components branch May 25, 2017 13:56
@zero-24 zero-24 added this to the Joomla 3.7.3 milestone Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants