[com_fields] Error message when creating a field with a name already existing

[stellainformatica]

Steps to reproduce the issue

Try to create a custom field (i.e. in contacts) that has the same name of a custom field created for another extension (i.e. contents).

Expected result

The ideal would be to let creating custom fields with the same name, if they are associated to different extensions, but, if not possible, a message should explain better why that field already exists.
I've modified the message like this:
COM_FIELDS_ERROR_UNIQUE_NAME="Another Field has the same name (remember it may be a trashed item or it may be already present as custom field in another extension)."

Actual result

appears this message:
"Save failed with the following error: Another Field has the same name (remember it may be a trashed item)."

Pull Request for Issue #16070 .

[zero-24]

@laoneo @Bakual is this the expected behavior? that you can only create one field with the same name over the cms?

[brianteeman]

as a custom field not as custom field

[stellainformatica]

Corrected, thanks Brian

[laoneo]

I see no limitation as it will be not possible to have two fields for two extensions on one form. I would rather break up that restriction than this pr.

[Bakual]

I see no limitation as it will be not possible to have two fields for two extensions on one form. I would rather break up that restriction than this pr.

The problem isn't the name of the field (which needs to be unique per form). It's the id of the field (which needs to be unique per page). And since you in theory can have multiple forms per page, that field name/id has to be unique sitewide.

[BertaOctech]

I have tested this item ✅ successfully on f3cc64f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16069.}

[ghost]

I have tested this item ✅ successfully on f3cc64f

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16069.}

[ghost]

Ready to Commit after two successful tests.