[tags] If we count false it returns 1 and not zero #16143
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #14747
Summary of Changes
$var = count(false) => 1 see: http://php.net/manual/en/function.count.php
@tonypartridge please check this too as this comes from #14747
Testing Instructions
Notice: Trying to get property of non-object in JRoot\components\com_tags\views\tag\view.html.php on line 120
Expected result
No error just the
No matching items were found.
messageActual result
The
No matching items were found.
plus a PHP notice:Notice: Trying to get property of non-object in JRoot\components\com_tags\views\tag\view.html.php on line 120
Documentation Changes Required
none