-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove closing slash as per Joomla Coding Guidelines #16151
Conversation
Ensure user provided data is correctly encoded
plugins/fields/media/tmpl/media.php
Outdated
$buffer .= '<img src="' . htmlentities($path) . '"' . $class . '>'; | ||
$buffer .= sprintf('<img src="%s"%s>', | ||
htmlentities($path, ENT_COMPAT, 'UTF-8', true), | ||
$class ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dedent lines 34 and 35.
I understand that this was not in the original code. In
|
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on a1e0b51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16151. |
There is a lot more than just removing the slash in this PR |
I don't see where the / is added back |
This comment was marked as abuse.
This comment was marked as abuse.
@PhilETaylor ok, then I'm really confuzzled because then we're breaking html? |
This comment was marked as abuse.
This comment was marked as abuse.
@N6REJ no we are not. html5 does not require the / |
@PhilETaylor I think I'll go back to contemplating why the hamster spins the wheel ... thanks |
@franz-wohlkoenig
and for media
|
I have tested this item ✅ successfully on a1e0b51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16151. |
This comment was marked as abuse.
This comment was marked as abuse.
RTC after two successful tests. |
@infograf768 didn't saw its about com_fields. |
Just removing a closing slash from an img tag to make @C-Lodder a happier little boy
Ensure user provided data is correctly encoded.