[4.0] Namespace com_fields #16187
Merged
[4.0] Namespace com_fields #16187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extensions itself
brianteeman
reviewed
May 22, 2017
| * | ||
| * @since 3.7.0 | ||
| * @since 3.0 |
There was a problem hiding this comment.
did you mean to change this?
brianteeman
reviewed
May 22, 2017
| * | ||
| * @since 3.7.0 | ||
| * @since 1.6 |
There was a problem hiding this comment.
did you meant to change this
brianteeman
reviewed
May 22, 2017
| * | ||
| * @since 3.7.0 | ||
| * @since 3.0 |
There was a problem hiding this comment.
again looks like you shouldnt have changed this
brianteeman
reviewed
May 22, 2017
| * | ||
| * @since 3.7.0 | ||
| * @since 1.6 |
brianteeman
reviewed
May 22, 2017
| * | ||
| * @see JModelLegacy | ||
| * @since 3.7.0 | ||
| * @since 1.6 |
|
Please review all the version number @SInCE changes - looks like a lot of copy paste errors. I started to comment inline on the code but there were too many |
|
Thanks @brianteeman, fixed the since params. |
brianteeman
reviewed
May 22, 2017
| @@ -106,12 +116,12 @@ protected function allowAdd($data = array()) | |||
| * | |||
| * @return boolean | |||
| * | |||
| * @since 1.6 | |||
| * @since 3.7.0 | |||
There was a problem hiding this comment.
shouldnt this be since 1.6
There was a problem hiding this comment.
or maybe it was wrong before
There was a problem hiding this comment.
it was wrong before, correctly it should be done against staging.
|
(title updated to show its for v4) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Namespace com_fields.
Some extras:
JModelLegacy::getInstance()