Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Update Codemirror to v5.26.0 #16215

Merged
merged 1 commit into from May 25, 2017
Merged

[4.0] Update Codemirror to v5.26.0 #16215

merged 1 commit into from May 25, 2017

Conversation

C-Lodder
Copy link
Member

Changelog

  • In textarea-mode, don't reset the input field during composition.
  • More careful restoration of selections in widgets, during editor redraw.
  • vim bindings: Parse line offsets in line or range specs.
  • javascript mode: More TypeScript parsing fixes.
  • julia mode: Fix issue where the mode gets stuck.
  • markdown mode: Understand cross-line links, parse all bracketed things as links.
  • soy mode: Support single-quoted strings.
  • go mode: Don't try to indent inside strings or comments.

@Fedik
Copy link
Member

Fedik commented May 23, 2017

why to 4.x and not to 3.x, is there B/C issue?

@C-Lodder
Copy link
Member Author

C-Lodder commented May 23, 2017

@Fedik - In 4.0 we use Grunt to manage vendor libraries. In 3.x it's a little different so it will need to be a separate PR. If I rightly remember, I think @brianteeman mentioned someone else normally managed the Codemirror updates for 3.x

@dgrammatiko
Copy link
Contributor

@C-Lodder @Fedik the person in charge is @okonomiyaki3000
Also the code in Grunt in J4 was based on his repo for the code mirror!

@wilsonge wilsonge merged commit 8fff7aa into joomla:4.0-dev May 25, 2017
@wilsonge wilsonge added this to the Joomla 4.0 milestone May 25, 2017
@C-Lodder C-Lodder deleted the codemirror560 branch May 25, 2017 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants