Extend the message to explain what is happening #16246

zero-24 · 2017-05-24T16:44:25Z

Pull Request for Issue #16238

Summary of Changes

In some broken hosting envoirments both mime checker tools are not enabled. In that case show that message with more extended info.

Testing Instructions

Try this on a broken hosting.
confirm the extended message
review the text.

Expected result

Extended text explaining what is happening

Actual result

Just a general message which is not longer match the usage.

Documentation Changes Required

None

mbabker · 2017-05-24T16:51:21Z

This needs to be crafted carefully. This message might be appropriate for the site owner who would be the primary POC regarding server configurations, but for a general user of the site this is too much information (they shouldn't be seeing a message saying "this server is incorrectly configured" basically, and that's what this message says).

zero-24 · 2017-05-24T16:52:27Z

I'm happy to accept a better suggestion. Maybe we show a different message in frontend and backend?

brianteeman · 2017-05-24T16:57:51Z

yes if possible to have a different message on the frontend that would be better

also please change him to them to make it gender neutral.

I will wait to hear if the message can be split before commenting on the text itself

mbabker · 2017-05-24T16:58:42Z

The error message needs to be somewhat vague as to the cause of the issue still (the user just needs to know the upload failed, not everyone needs to know the technical reasoning for the failure), but we should be making it possible for site owners to get more information about why the issue happened. Long and short, we need to start making more liberal use of our logging system and stop expecting that the only way to get information about an error state is through messages displayed to the user in the alert container.

So a message displayed in the UI should basically say not much more than "could not upload file because the MIME type could not be determined". A supplemental JLog::add() call should be used to log additional details (upload of X file failed because the MIME type could not be determined).

zero-24 · 2017-05-24T16:59:16Z

I will wait to hear if the message can be split

Yes it can as we have different language files for backend and frontend.

brianteeman · 2017-05-24T17:04:39Z

first attempt

Frontend

+JLIB_MEDIA_ERROR_WARNINVALID_MIME="We were unable to upload this file."

Backend

+JLIB_MEDIA_ERROR_WARNINVALID_MIME="We could not detect the mime type for this file. For security purposes this file has not been uploaded. Please contact your host to check that the mime_content_type or the fileinfo extension is enabled in php."

zero-24 · 2017-05-24T17:15:38Z

done with the last commit.

Quy · 2017-05-24T17:15:41Z

I prefer not to not use We were and We could since we don't use We in the other strings.

How about?

Unable to upload this file.

Unable to detect mime type for this file. For security purposes have not uploaded this file. Please contact your host and to check that mime_content_type or the fileinfo extension is enabled in PHP.

brianteeman · 2017-05-24T17:17:02Z

i was trying to be more friendly - but if not then

Unable to upload this file.

Unable to detect the mime type for this file. For security purposes this file has not been uploaded . Please contact your host and check that the mime_content_type or the fileinfo extension is enabled in PHP.

zero-24 · 2017-05-24T17:19:26Z

pushed thanks

brianteeman · 2017-05-24T17:21:17Z

administrator/language/en-GB/en-GB.lib_joomla.ini

@@ -670,7 +670,8 @@ JLIB_MEDIA_ERROR_WARNFILETOOLARGE="This file is too large to upload."
 JLIB_MEDIA_ERROR_WARNFILETYPE="This file type is not supported."
 JLIB_MEDIA_ERROR_WARNIEXSS="Possible IE XSS Attack found."
 JLIB_MEDIA_ERROR_WARNINVALID_IMG="Not a valid image."
-JLIB_MEDIA_ERROR_WARNINVALID_MIME="Invalid mime type detected."
+; Do not sync that line with the frontend! This is expected to be different from the frontend string.


the next line instead of that line
please

Quy · 2017-05-24T17:21:20Z

i was trying to be more friendly - but if not then

I totally understand. Just going for consistency sake.

brianteeman · 2017-05-24T17:21:39Z

administrator/language/en-GB/en-GB.lib_joomla.ini

@@ -670,7 +670,8 @@ JLIB_MEDIA_ERROR_WARNFILETOOLARGE="This file is too large to upload."
 JLIB_MEDIA_ERROR_WARNFILETYPE="This file type is not supported."
 JLIB_MEDIA_ERROR_WARNIEXSS="Possible IE XSS Attack found."
 JLIB_MEDIA_ERROR_WARNINVALID_IMG="Not a valid image."
-JLIB_MEDIA_ERROR_WARNINVALID_MIME="Invalid mime type detected."
+; Do not sync that line with the frontend! This is expected to be different from the frontend string.
+JLIB_MEDIA_ERROR_WARNINVALID_MIME="Unable to detect the mime type for this file. For security purposes this file has not been uploaded . Please contact your host and check that the mime_content_type or the fileinfo extension is enabled in PHP."


extra space after uploaded

sorry

Quy · 2017-05-24T19:54:04Z

How about removing this file from the 1st sentence since it is mentioned (redundant) in the second sentence?

Unable to detect the mime type. For security purposes this file has not been uploaded. Please contact your host and check that the mime_content_type or the fileinfo extension is enabled in PHP.

brianteeman · 2017-05-24T22:09:03Z

Fine by me

brianteeman · 2017-05-25T08:28:33Z

I have tested this item ✅ successfully on 11a71e9

on review

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16246.}

brianteeman · 2017-05-25T08:30:32Z

just had a thought and running for a train so cant test BUT is this message also displayed when you are trying to upload an file that is not in the allowed mime types that are saved in the com-media options? If so then this new message is not correct

zero-24 · 2017-05-25T08:39:52Z

No than we have a differnent message that also include the detected mime type.
This message is only displayed if we could not detect a mimetype and this means that both methos are not enabled.

brianteeman · 2017-05-25T08:52:59Z

ok all good then

Quy · 2017-05-25T09:28:09Z

I have tested this item ✅ successfully on 11a71e9

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16246.}

ghost · 2017-05-25T09:31:30Z

RTC after two successful tests.

mbabker · 2017-05-25T12:04:44Z

I am still going to be insistent that the UI does not use an error message that says "you need X PHP extension/function enabled". That comment is only beneficial if the only user who may see it is the site owner or can manage their server configuration.

brianteeman · 2017-05-25T12:07:31Z

@mbabker are the people who can see that message different to the people who can see the php update message?

mbabker · 2017-05-25T12:09:13Z

Depending on how you have the plugin configured or your site's ACL, yes, it could be a different group.

rdeutz · 2017-05-25T13:44:55Z

seems to me not really discussed how it should be, state set to "needs review"

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16246.}

…e_error_message

…me_error_message

zero-24 · 2017-08-13T14:12:52Z

I'm closing here as it looks like we can not find a consense here. Thanks.

extend the message

821ef18

joomla-cms-bot added Language Change This is for Translators PR-staging labels May 24, 2017

This was referenced May 24, 2017

fix mime checkes #16091

Merged

PDF files not uploading with PHP 7 and Joomla 3.7.2 #16238

Closed

better messages

9b1f156

even better texts thanks

deecbab

brianteeman reviewed May 24, 2017

View reviewed changes

fixes

11a71e9

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 25, 2017

rdeutz added this to the Joomla 3.7.3 milestone May 25, 2017

rdeutz removed the RTC This Pull Request is Ready To Commit label May 25, 2017

joomla-cms-bot removed this from the Joomla 3.7.3 milestone May 25, 2017

Merge branch 'master' of github.com:joomla/joomla-cms into better_mim…

d8d8fc2

…e_error_message

zero-24 force-pushed the better_mime_error_message branch from 065623f to d8d8fc2 Compare June 14, 2017 18:21

zero-24 added 7 commits June 14, 2017 20:22

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

08868e4

…me_error_message

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

0f9e5b7

…me_error_message

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

510abe9

…me_error_message

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

ee01851

…me_error_message

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

8b52c0e

…me_error_message

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

7346c6c

…me_error_message

Merge branch 'staging' of github.com:joomla/joomla-cms into better_mi…

f801ea2

…me_error_message

zero-24 closed this Aug 13, 2017

zero-24 deleted the better_mime_error_message branch August 13, 2017 14:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extend the message to explain what is happening #16246

Extend the message to explain what is happening #16246

zero-24 commented May 24, 2017 •

edited by joomla-cms-bot

mbabker commented May 24, 2017

zero-24 commented May 24, 2017

brianteeman commented May 24, 2017 •

edited

mbabker commented May 24, 2017

zero-24 commented May 24, 2017 •

edited by brianteeman

brianteeman commented May 24, 2017 •

edited

zero-24 commented May 24, 2017

Quy commented May 24, 2017

brianteeman commented May 24, 2017

zero-24 commented May 24, 2017

brianteeman May 24, 2017

zero-24 May 24, 2017

Quy commented May 24, 2017

brianteeman May 24, 2017

zero-24 May 24, 2017

Quy commented May 24, 2017

brianteeman commented May 24, 2017

brianteeman commented May 25, 2017

brianteeman commented May 25, 2017

zero-24 commented May 25, 2017

brianteeman commented May 25, 2017

Quy commented May 25, 2017

ghost commented May 25, 2017

mbabker commented May 25, 2017

brianteeman commented May 25, 2017

mbabker commented May 25, 2017

rdeutz commented May 25, 2017

zero-24 commented Aug 13, 2017

Extend the message to explain what is happening #16246

Extend the message to explain what is happening #16246

Conversation

zero-24 commented May 24, 2017 • edited by joomla-cms-bot

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

mbabker commented May 24, 2017

zero-24 commented May 24, 2017

brianteeman commented May 24, 2017 • edited

mbabker commented May 24, 2017

zero-24 commented May 24, 2017 • edited by brianteeman

brianteeman commented May 24, 2017 • edited

Frontend

Backend

zero-24 commented May 24, 2017

Quy commented May 24, 2017

brianteeman commented May 24, 2017

zero-24 commented May 24, 2017

brianteeman May 24, 2017

Choose a reason for hiding this comment

zero-24 May 24, 2017

Choose a reason for hiding this comment

Quy commented May 24, 2017

brianteeman May 24, 2017

Choose a reason for hiding this comment

zero-24 May 24, 2017

Choose a reason for hiding this comment

Quy commented May 24, 2017

brianteeman commented May 24, 2017

brianteeman commented May 25, 2017

brianteeman commented May 25, 2017

zero-24 commented May 25, 2017

brianteeman commented May 25, 2017

Quy commented May 25, 2017

ghost commented May 25, 2017

mbabker commented May 25, 2017

brianteeman commented May 25, 2017

mbabker commented May 25, 2017

rdeutz commented May 25, 2017

zero-24 commented Aug 13, 2017

zero-24 commented May 24, 2017 •

edited by joomla-cms-bot

brianteeman commented May 24, 2017 •

edited

zero-24 commented May 24, 2017 •

edited by brianteeman

brianteeman commented May 24, 2017 •

edited