Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/libraries/fof/integration/joomla/platform.php contains calls of the deprecated method JApplicationCms->isAdmin() #16269

Closed
nvyush opened this issue May 26, 2017 · 1 comment

Comments

@nvyush
Copy link
Contributor

nvyush commented May 26, 2017

Steps to reproduce the issue

Open the file /libraries/fof/integration/joomla/platform.php and search the string JFactory::getApplication()->isAdmin()

Expected result

The string is not found, because the method JApplicationCms->isAdmin() is deprecated and must be replaced with JApplicationCms->isClient('administrator').

Actual result

The string is found at lines 151 and 820.

System information (as much as possible)

Joomla! 3.7.1.

Additional comments

@zero-24
Copy link
Contributor

zero-24 commented May 26, 2017

As this is unmaintained 3rd party code as well it is going to be removed in joomla 4.0. I think we are save here. As the old method is also included until 4.0 :)

Closing for that reason thanks.

@zero-24 zero-24 closed this as completed May 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants