Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][Aurora] Remove PHP logic to set column width #16744

Merged
merged 1 commit into from
Jun 18, 2017

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Jun 18, 2017

Pull Request for Issue # .

Summary of Changes

Removes the PHP logic which sets the component area width depending on modules published in the sidebar-left and/or sidebar-right module positions. This can now be done automatically with flexbox

Testing Instructions

Apply patch and ensure the component area width adjusts correctly when modules are published/unpublished in the sidebar-left and sidebar-right module positions.

Documentation Changes Required

No

@C-Lodder
Copy link
Member

Working fine on FF, Chrome, Edge and IE11

@ghost
Copy link

ghost commented Jun 18, 2017

@C-Lodder should i alter your Test successfully?

@wilsonge wilsonge merged commit d70ba52 into joomla:4.0-dev Jun 18, 2017
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 18, 2017
@ciar4n ciar4n deleted the aurora-sidecol-logic branch July 13, 2017 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants