Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to use tinymce params #16771

Closed
wants to merge 4 commits into from
Closed

Conversation

alex7r
Copy link
Contributor

@alex7r alex7r commented Jun 19, 2017

Redo of #16387 to force travis to start

Summary of Changes

Allow to set tinymce parameters like

$options = array(
        'inline'=>true,
        'menubar'=>false,
);
echo $editor->display( 'new_incorrect_feed', '', 500, 170, '20', '10', true, null, null, null, $options )

Testing Instructions

Pass options to the $editor, for example inline => true

Expected result

Tinymce is in inline mode.

Actual result

Tinymce is not in inline mode.

@alex7r
Copy link
Contributor Author

alex7r commented Jun 19, 2017

@wilsonge
Just so you know that it's restarted.

@alex7r
Copy link
Contributor Author

alex7r commented Jun 19, 2017

Ok, now drone hangs XD

@Quy
Copy link
Contributor

Quy commented Jun 19, 2017

Warning is displayed above the editor when editing an article.

Notice: Undefined index: tinyMCE in C:\xampp\htdocs\joomla-cms\plugins\editors\tinymce\tinymce.php on line 202

@alex7r
Copy link
Contributor Author

alex7r commented Jun 19, 2017

Hm... It seems like the part responsible for that may be at $doc->getScriptOptions and not in changed code. But I'll check and fix, thanks for test.

@alex7r
Copy link
Contributor Author

alex7r commented Jul 6, 2017

@Quy ok, it's should be fixed now.

@Quy
Copy link
Contributor

Quy commented Jul 6, 2017

A different error now with default install.

Notice: Undefined index: articletext in C:\xampp\htdocs\joomla-cms\plugins\editors\tinymce\tinymce.php on line 207

@Quy
Copy link
Contributor

Quy commented Jan 5, 2018

@alex7r Please advise status.

@alex7r
Copy link
Contributor Author

alex7r commented Jan 24, 2018

Sorry, were not able to get back to contribute to the repo in some time already. I'll try to update the branch in a few days.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/16771

@Quy
Copy link
Contributor

Quy commented May 10, 2018

Closing for now and can be opened if/when you have time.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/16771.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants