fixed missing own asset rule for parent recursive get access rule

[julienV]

Pull Request for Issue # .

Summary of Changes

Fixed a failing strict comparison operator, which prevents parent recursive asset rule to work properly
self::$assetPermissionsParentIdMapping[$extensionName][$id] is the result of a database query, so the type of self::$assetPermissionsParentIdMapping[$extensionName][$id]->id is string.
$assetId if an integer, so the test result is false, but it should be true...

Testing Instructions

Not easy to test, as this parameters don't seem to be use directly in joomla core...

Expected result

Actual result

Documentation Changes Required

none

[csthomas]

IMO It would be better to set this more explicitly, I mean using (int) $a !== $b. I know that does not change anything in php but for people it is more explicit.

[julienV]

sure, i can change it to
(int) self::$assetPermissionsParentIdMapping[$extensionName][$id]->id, but does it really makes it more readable ? the variable name is so long, you don't really see the type casting.

[ggppdk]

sure, i can change it to
(int) self::$assetPermissionsParentIdMapping[$extensionName][$id]->id, but does it really makes it more readable ? the variable name is so long, you don't really see the type casting.

it a not only about readability, which i argue it is quite readable , it is not too long,
it will also make clear to people looking at the code in the future what the comparison does, thus avoid the bug being re-introduced by future modifications

[julienV]

@ggppdk i added the casting to int

[mbabker]

All this critique about type casting and no follow on...

(Needs merge conflicts resolved)

[julienV]

there was no conflict, merging of staging branch went fine...

[SharkyKZ]

I have tested this item ✅ successfully on fc4d255

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17009.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17009.}

[HLeithner]

Finally a happy end. Thanks