[4.0] Move searchtools, sort and item count to dropdown #17059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you make the dropdown collapse when you click away please |
|
I have tested this item ✅ successfully on abdd678 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17059. |
|
@brianteeman Dropdown now closes with click away |
|
I have tested this item ✅ successfully on 1e72e40 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17059. |
C-Lodder
reviewed
Jul 11, 2017
| .custom-select { | ||
| &.active { | ||
| color: #fff; | ||
| background: #fefefe url("data:image/svg+xml;charset=utf8,%3Csvg xmlns=\'http://www.w3.org/2000/svg\' viewBox=\'0 0 4 5\'%3E%3Cpath fill=\'%23fff\' d=\'M2 0L0 2h4zm0 5L0 3h4z\'/%3E%3C/svg%3E") no-repeat scroll right .75rem center / 8px 10px; |
C-Lodder
reviewed
Jul 11, 2017
| @@ -110,7 +110,7 @@ | |||
| self.filterButton.addEventListener('click', function(e) { | |||
| self.toggleFilters(); | |||
| e.stopPropagation(); | |||
| e.preventDefault(); | |||
| e.preventDefault(); | |||
There was a problem hiding this comment.
Remove whitespace after e.preventDefault();
|
I have tested this item ✅ successfully on 1e72e40 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17059. |
|
works great with core. Looks odd with com-patchtester. not sure if thats an issue or not This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17059. |
|
com_patchtester doesn't use search tools since it's not using the "legacy" MVC. So I'm kind of winging it in the 4.0 layouts to make it look similar. |
|
@mbabker all good then ;) |
C-Lodder
approved these changes
Jul 12, 2017
brianteeman
pushed a commit
to brianteeman/joomla-cms
that referenced
this pull request
Jul 14, 2017
* Move searchtools to dropdown * Add eventlistener to body to close dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Moves searchtools, sort and item count to a dropdown menu under a 'Table Options' toggle in list views.
Testing Instructions
Apply patch and navigate to list view (Articles).
Before
After
Documentation Changes Required
Yes