Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare also the intro text in the article details view #17175

Merged
merged 1 commit into from
Aug 20, 2017

Conversation

laoneo
Copy link
Member

@laoneo laoneo commented Jul 19, 2017

Pull Request for Issue #15751.

Summary of Changes

Triggers the prepare event also on the intro text in the article details view. So are plugins triggered on the intro text as well.

Testing Instructions

  • Insert Field in Article
  • Article Options - Set Linked Titles to Yes, Show Unauthorised Links to Yes, Show Intro Text to Hide,
  • Set Article Access to Registered
  • Create any custom field with access right to public and insert in the article before read more (intro text)
  • Create category blog menu item
  • Check front end as non logged in user.

Expected result

Clicking on article title should show inserted field value.

Actual result

Clicking on article title show field name as (field --}

@laoneo laoneo changed the title [com_fields] Prepare also the intro text Prepare also the intro text in the article details view Jul 19, 2017
@ghost
Copy link

ghost commented Jul 19, 2017

I have tested this item ✅ successfully on 1493c9e

Hint: In Menu > Options Show Unauthorised Links set to Use Article Settings then Article is displayed > @laoneo can you please update Test Instructions?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17175.

@ghost
Copy link

ghost commented Jul 20, 2017

@esskay303 please test this PR.

@esskay303
Copy link

Hello...Thanks for your response and extremely sorry for not responding in time. I have coped the site to another server. I am sorry but would like to know what is the best way to test it. Is it okay if I copy components/com_content/views/article/view.html.php this file to the test server and check the behaviour? Sorry once again for the basics but new here...

@brianteeman
Copy link
Contributor

@esskay303
Copy link

Hi Brian...Thanks for your guidance. It seems that the issue is fixed with this patch. However, I will be able to do in depth testing only by tomorrow and see whether everything is working as expected or not.
Meanwhile, what should be done for the applied patch? Should I keep it as it is i.e. applied or I need to revert it?

@esskay303
Copy link

I can confirm that this has fixed my issue. Will this be a part of the next release?

@ghost
Copy link

ghost commented Aug 12, 2017

@esskay303 can you please submit the successfully Test at https://issues.joomla.org/tracker/joomla-cms/17175?

Now this PR has 2 succefully Tests and maintainers decide if it goes in next Release (Hint: Feature Freeze was a few Days ago so normally it can't come with next Release).

@esskay303
Copy link

I have tested this item ✅ successfully on 1493c9e

Tested successfully and working...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17175.

@ghost
Copy link

ghost commented Aug 20, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 20, 2017
@mbabker mbabker added this to the Joomla 3.8.0 milestone Aug 20, 2017
@mbabker mbabker merged commit 605a2f1 into joomla:staging Aug 20, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 20, 2017
@laoneo laoneo deleted the cf/process-intro-text branch August 20, 2017 16:42
@regularlabs
Copy link
Contributor

This needs to get reverted asap. See discussion on: #18016

laoneo added a commit to Digital-Peak/joomla-cms that referenced this pull request Sep 22, 2017
mbabker pushed a commit that referenced this pull request Sep 26, 2017
* Revert "Prepare also the intro text (#17175)"

This reverts commit 605a2f1

* Prepare also the intro text

* Dockblock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants