Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated installation language files #17197

Merged
merged 2 commits into from Jul 21, 2017

Conversation

Bakual
Copy link
Contributor

@Bakual Bakual commented Jul 20, 2017

Merge by review once Travis passed.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Jul 20, 2017
@Bakual Bakual added this to the Joomla 3.7.4 milestone Jul 20, 2017
@ghost
Copy link

ghost commented Jul 21, 2017

Travis is passed.

@brianteeman
Copy link
Contributor

I see that we are still accepting translations that are translating the name of the installation folder :(

Can we please not merge these obviously incorrect translations

@Bakual
Copy link
Contributor Author

Bakual commented Jul 21, 2017

I'm not going to play "translation police".

@brianteeman
Copy link
Contributor

This is crazy - we have an obvious mistake in the translation - we should not be merging anything that is incorrect

@Bakual
Copy link
Contributor Author

Bakual commented Jul 21, 2017

The question is who is going to enforce that? I refuse to do that. I do check the technical correctness of the files to a degree, but not the content of the translation. That one is the responsibility of the translator.

Imho, the users of those languages should open a complain/issue with their respective translation teams. If they don't care, I will not care as well.

@brianteeman
Copy link
Contributor

I guess it is time to take this seriously then and if you wont then we need someone who will ;(

@brianteeman
Copy link
Contributor

I apologise for caring

@infograf768 infograf768 merged commit 247480f into joomla:staging Jul 21, 2017
@Bakual Bakual deleted the UpdateInstallationLanguage branch July 21, 2017 13:35
@syntaxerror
Copy link

It's the same "mistake" in the English files, using uppercase letters etc ...

If that "logic" of you @brianteeman should make any sense, it would need to be changed also in English. Because it's actually telling the exact same thing in English as it would in any other language when it's translated, for all those strings.

Like here it's also uppercase:
INSTL_COMPLETE_FOLDER_REMOVED="Installation folder removed."

To make your reasoning make any sense, it would need to be changed into something like:
INSTL_COMPLETE_FOLDER_REMOVED="The "installation" folder was removed."

Else there isn't anything more to waste time on, and pollute every language PR with, like a child trying to get his/her will this way ... Agree or disagree ...

@mbabker
Copy link
Contributor

mbabker commented Jul 24, 2017

@syntaxerror It's very obvious you have a dislike for Brian, there is no need to comment on every pull request arguing with him if you aren't going to add anything productive to the conversation.

@syntaxerror
Copy link

Oh, it seems like it's Brian having to post and post on every PR ... And I added something productive here, for those who care about others opinions.

@mbabker
Copy link
Contributor

mbabker commented Jul 24, 2017

You were fine until you started with the personal shots at the end. Leave those out of your posts if you really feel compelled to reply.

And you may look at it like someone crying, but fact of the matter is Brian is one of the few contributors who is a native English (British type) speaker, so I would hope he is doing a level of QA checks and "being childish" for the sake of ensuring things are consistent and grammatically correct, the same way others do levels of QA checks for things like code style or efficient (or even correct) PHP/JavaScript code.

@syntaxerror
Copy link

So then he's allowed to do as he like. Treat people, translators and others like s h i t - so they don't care to contribute. Well ... that says it all ...

@mbabker
Copy link
Contributor

mbabker commented Jul 24, 2017

No, he is not free to do as he likes. And I fail to see the issue with him pointing out that the translation teams are not following instructions and providing potentially incorrect translations. If that's really seen as whining, then realistically any level of QA is whining.

@syntaxerror
Copy link

Still he does in PR after PR, forums, Twitter etc. Using a level of language others are not allowed to.

And yes, he's a native British English speaker, not a native in other languages. So it's at it best only potential mistakes, assumed mistakes. But still it's being nagged about in PR after PR, without being a good example fixing the real issues in English instead.

Pointing out is one thing, nagging is another.

@rdeutz
Copy link
Contributor

rdeutz commented Jul 24, 2017

If there is a problem make a PR or open an issue, enough said here

@joomla joomla locked and limited conversation to collaborators Jul 24, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants