Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Correcting mod_sampledata trigger event #17617

Merged
merged 2 commits into from
Aug 19, 2017

Conversation

infograf768
Copy link
Member

Pull Request for Issue #17612

Summary of Changes

JEventDispatcher is not used any more in 4.0

Testing Instructions

Before patch:

screen shot 2017-08-19 at 08 51 32

After patch

screen shot 2017-08-19 at 10 34 49

Actual result

Documentation Changes Required

@infograf768
Copy link
Member Author

Note: fof in 4.0 is also using $dispatcher = JEventDispatcher::getInstance();

Sample data plugins can't be installed, but this is different bug.

@brianteeman
Copy link
Contributor

Fof is to be removed in j4

@infograf768
Copy link
Member Author

I guess Travis failure has nothing to do with this PR.

@wilsonge wilsonge merged commit c0527ee into joomla:4.0-dev Aug 19, 2017
@wilsonge wilsonge added this to the Joomla 4.0 milestone Aug 19, 2017
@infograf768 infograf768 deleted the 4.0triggerevent branch August 19, 2017 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants