[4.0] webcomponents everywhere, media field #17740
Conversation
dgrammatiko
changed the title
layouts/joomla/form/field/media.php
Outdated
| basepath="<?php echo JUri::root(); ?>" | ||
| rootfolder="<?php echo ComponentHelper::getParams('com_media')->get('file_path', 'images'); ?>" | ||
| url="<?php echo $url; ?>" | ||
| modalcont=".modal" |
There was a problem hiding this comment.
what is this one? Can it have an easier to understand name?
There was a problem hiding this comment.
guessing from line 106 it should be "modalcontainer" ?
There was a problem hiding this comment.
Actually my naming convention is bad. I will change all these to hyphen separated words: basepath -> base-path
There was a problem hiding this comment.
Ok, attribute names back to kebab case.
Also fix the stretched preview image
add (hardcoded ATM) support for more media types
and prepared for the changes in the media manager
|
Looks like you have a bug ;) |
|
It's this line: |
layouts/joomla/form/field/media.php
Outdated
| @@ -76,6 +76,12 @@ | |||
| { | |||
| $src = JText::_('JLIB_FORM_MEDIA_PREVIEW_EMPTY'); | |||
| } | |||
|
|
|||
| if ($showAsTooltip) { | |||
There was a problem hiding this comment.
$showPreview = 'static';
if ($showAsTooltip)
{
$showPreview = 'tooltip';
}There was a problem hiding this comment.
Re assigning a variable is slower than an if/else but anyways I did it
|
I have tested this item ✅ successfully on e65c4c1 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17740. |
|
the field seems works, but I cannot see any image in modal, |
|
This is already merged, from the new media manager repo |
Pull Request for Issue # .
Summary of Changes
REQUESTING FOR SOME BETTER DESIGN
If any designer comes along this PR and they feel that this part needs some redesign love, please do help and provide some mockups
Testing Instructions
Edit an article and change the intro and full text images
Expected result
Same functionality as 3.x
Actual result
Documentation Changes Required
NOPE