Menu manager delete error message color is wrong #17796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on d759fd0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17796. |
1 similar comment
|
I have tested this item ✅ successfully on d759fd0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17796. |
|
RTC after two successful tests. |
joomla-cms-bot
added
PR-staging
and removed
RTC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #17729
Summary of Changes
Set mesage type to error
Testing Instructions
Do something that fails menu deletion. e.g - add
return falsewith some dummysetErrormessage fromMenusModelMenu::deletemethod.Expected result
Red error message
Actual result
Green error message
Documentation Changes Required
None