Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Fix site title #17831

Closed
wants to merge 11 commits into from
Closed

[4.0] Fix site title #17831

wants to merge 11 commits into from

Conversation

lufog
Copy link

@lufog lufog commented Sep 2, 2017

Fix site title
before
before
after
after

@@ -26,8 +26,11 @@
display: inline-block;
padding: 0;
margin-right: 3rem;
font-size: 2rem;
color: $white-offset;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains trailing whitespace

@joomla-cms-bot joomla-cms-bot changed the title 4.0 dev [4.0] Fix site title Sep 2, 2017
@ghost
Copy link

ghost commented Sep 2, 2017

changed Title meaningful.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17831.

font-size: 2rem;
color: #fefefe; }
margin-right: 3rem; }
.hgeader .navbar-brand a {
Copy link
Contributor

@ciar4n ciar4n Sep 2, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.hgeader? I'm guessing this should be .header?

@ciar4n
Copy link
Contributor

ciar4n commented Sep 2, 2017

@DebuggeR94 You appear to have some differences between the SCSS and CSS. Have you edited the SCSS and then compiled to CSS or simply edited both manually?

@C-Lodder
Copy link
Member

C-Lodder commented Sep 2, 2017

Please do not try and manually edit thetemplate.css. It will get automatically generated when you run:
grunt compile:site

@lufog
Copy link
Author

lufog commented Sep 2, 2017

@ciar4n Yes, I fixed the files straight through the Web interface, and made a typo. In the future, I will do as it should be :)

@C-Lodder
Copy link
Member

C-Lodder commented Sep 2, 2017

@DebuggeR94 - Please fix the error reported by Hound too

wilsonge and others added 2 commits September 2, 2017 20:20
Otherwise, the links looks like:
   site.domain/profile/en?view=profile
Instead of:
   site.domain/en/profile?view=profile
@lufog
Copy link
Author

lufog commented Sep 3, 2017

Sorry, I'm still not quite clear with the github interface, and instead of create new pull request I sent another fix here.
Unfortunately I do not know how to remove it.

@wojsmol
Copy link
Contributor

wojsmol commented Sep 3, 2017

@DebuggeR94 Just do new commit and revert 9cee0d1.

@Quy
Copy link
Contributor

Quy commented Nov 25, 2017

I assume this is no longer applicable.

@Quy
Copy link
Contributor

Quy commented Nov 27, 2017

@franz-wohlkoenig Close since this is for the no longer available aurora template?

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17831

@ghost
Copy link

ghost commented Nov 27, 2017

closed as stated above.

thanks for Hint @Quy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants