New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Fix site title #17831
[4.0] Fix site title #17831
Conversation
@@ -26,8 +26,11 @@ | |||
display: inline-block; | |||
padding: 0; | |||
margin-right: 3rem; | |||
font-size: 2rem; | |||
color: $white-offset; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains trailing whitespace
changed Title meaningful. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17831. |
templates/aurora/css/template.css
Outdated
font-size: 2rem; | ||
color: #fefefe; } | ||
margin-right: 3rem; } | ||
.hgeader .navbar-brand a { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.hgeader
? I'm guessing this should be .header
?
@DebuggeR94 You appear to have some differences between the SCSS and CSS. Have you edited the SCSS and then compiled to CSS or simply edited both manually? |
Please do not try and manually edit the |
@ciar4n Yes, I fixed the files straight through the Web interface, and made a typo. In the future, I will do as it should be :) |
@DebuggeR94 - Please fix the error reported by Hound too |
Otherwise, the links looks like: site.domain/profile/en?view=profile Instead of: site.domain/en/profile?view=profile
Sorry, I'm still not quite clear with the github interface, and instead of create new pull request I sent another fix here. |
@DebuggeR94 Just do new commit and revert 9cee0d1. |
I assume this is no longer applicable. |
@franz-wohlkoenig Close since this is for the no longer available aurora template? |
Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/17831 |
closed as stated above. thanks for Hint @Quy. |
Fix site title
before
after