Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_modules] - fix Notice: Undefined variable: clientId #17983

Merged
merged 1 commit into from
Sep 19, 2017
Merged

[com_modules] - fix Notice: Undefined variable: clientId #17983

merged 1 commit into from
Sep 19, 2017

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Sep 19, 2017

Pull Request for Issue #17982.

Summary of Changes

fix Notice: Undefined variable: clientId

Testing Instructions

Edit an article.
Click Module button in the editor.

Expected result

No notice

fix Notice: Undefined variable: clientId
@ghost
Copy link

ghost commented Sep 19, 2017

I have tested this item ✅ successfully on 4db0b1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17983.

@izharaazmi
Copy link
Contributor

I have tested this item ✅ successfully on 4db0b1f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/17983.

@izharaazmi
Copy link
Contributor

IMO, this should go in 3.8.0 milestone

@ghost
Copy link

ghost commented Sep 19, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 19, 2017
@infograf768
Copy link
Member

@mbabker

@mbabker mbabker added this to the Joomla 3.8.0 milestone Sep 19, 2017
@mbabker mbabker merged commit ad46b54 into joomla:staging Sep 19, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Sep 19, 2017
@alikon alikon deleted the patch-97 branch September 19, 2017 11:29
@tstransco
Copy link

I lost some of the components from components list after I updated to 3.8 from 3.75. How can I get back my those components back viz. breezingforms, fabrik etc Can anybody help me plz?

@ghost
Copy link

ghost commented Sep 19, 2017

@tstransco Please ask help on the forums. This repository concerns Joomla coding, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants