Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passing a null value for the first argument of Text::script() is depr… #18101

Merged
merged 1 commit into from
Dec 21, 2017
Merged

Passing a null value for the first argument of Text::script() is depr… #18101

merged 1 commit into from
Dec 21, 2017

Conversation

joomlart
Copy link
Contributor

@joomlart joomlart commented Sep 25, 2017

…ecated

Use Text::getScriptStrings() instead.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Expected result

Actual result

Documentation Changes Required

…ecated

Use Text::getScriptStrings() instead.
@ghost
Copy link

ghost commented Oct 28, 2017

Can you give Test Instructions so People with less Dev-Knowledge can test?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18101.

@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 18, 2017
@Quy
Copy link
Contributor

Quy commented Dec 19, 2017

Go to Extensions > Plugins > System - Debug.
Under Logging tab, enable Log Deprecated API.
Go to the frontend.
Open the log file @ \administrator\logs\deprecated.php
Search for As of 3.7.0, passing a null value for the first argument of Joomla\CMS\Language\Text::script() is deprecated and will not be supported in 4.0. Use the Joomla\CMS\Language\Text::getScriptStrings() method to get the strings from the JavaScript language store instead.
After PR, no warning above.

@Quy
Copy link
Contributor

Quy commented Dec 19, 2017

I have tested this item ✅ successfully on 963fee1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18101.

@ghost
Copy link

ghost commented Dec 20, 2017

@Quy without PR got 300+ Warnings but not the one you wrote.

@Quy
Copy link
Contributor

Quy commented Dec 20, 2017

Please try again with the Test English (GB) Sample Data demo.

@ghost
Copy link

ghost commented Dec 20, 2017

I have tested this item ✅ successfully on 963fee1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18101.

@ghost
Copy link

ghost commented Dec 20, 2017

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 20, 2017
@mbabker mbabker added this to the Joomla 3.8.4 milestone Dec 21, 2017
@mbabker mbabker merged commit 0531d2f into joomla:staging Dec 21, 2017
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 21, 2017
photodude pushed a commit to photodude/joomla-cms that referenced this pull request Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants