Correct the menutype descriptions #18191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR for joomla#16200 The description for the menu heading and text sperator types are incorect The heading is only for a parent eg Users and it cannot be used to seperate items within a menu. Thats what the text seperator is for
Quy
reviewed
Oct 2, 2017
| COM_MENUS_TYPE_SEPARATOR="Text Separator" | ||
| COM_MENUS_TYPE_SEPARATOR_DESC="A text separator." | ||
| COM_MENUS_TYPE_SEPARATOR_DESC="A text separator, useful to seperate items within a menu." |
ghost
mentioned this pull request
|
I have tested this item ✅ successfully on 035ce9a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18191. |
1 similar comment
|
I have tested this item ✅ successfully on 035ce9a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18191. |
|
RTC after two successful tests. |
|
Apparently should not be RTC |
|
forget it, it was corrected. |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #16200
The description for the menu heading and text sperator types are incorect
The heading is only for a parent eg Users and it cannot be used to seperate items within a menu. Thats what the text seperator is for