User profile form is prepated twice in frontend. #18065

[Denitz]

Pull Request for Issue #18065

Steps to reproduce the issue

debug FieldsHelper::prepareForm() and see that it's launched twice in frontend:

Initially via PlgSystemFields->onContentPrepareForm event and see that it's launched twice in frontend.

Next FieldsHelper::prepareForm() is called again via UsersModelProfile::getForm()

Expected result

FieldsHelper::prepareForm() should be called once on user profile form display.

Actual result

Called twice

[Denitz]

Who can fix AppVeyor issue with sqlite for PHP 5.6?

http://ci.joomla.org/joomla/joomla-cms/136 fails as well.

[stutteringp0et]

This PR solves #18427 (now closed) - how can I help?

[ghost]

@stutteringp0et please mark your Test as successfully:

• open Issue Tracker
• Login with your github-Account
• Click on blue "Test this"-Button above Authors-Picture
• mark your Test as successfully
• hit "submit test result"

[stutteringp0et]

I have tested this item ✅ successfully on 3a1b635

Fields are still rendered, FieldsHelper::prepareForm is executed only once.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18211.}

[stutteringp0et]

Done - looking forward to seeing this update in the next release. This issue was killing a feature of an extension I'm about to release.

[csthomas]

I have tested this item ✅ successfully on 3a1b635

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18211.}

[stutteringp0et]

I was playing around with this, and with the patch applied - the user profile fields are still rendered, and work correctly for the most part - but when I tried a "color" type field, the value doesn't get stored. It works for any other custom fields I create, but not the color type. I suspect this should be raised as a separate issue - but thought I should mention it here. When I try this on a vanilla 3.8.1 the color value is stored as expected.

[ghost]

@stutteringp0et can you please open a new Issue?

[ghost]

RTC after two successful tests.

[stutteringp0et]

Can I raise an issue based on a PR that hasn't been merged yet?

[stutteringp0et]

Scratch my report about the color field type - I went through my settings and found that I forgot to give the user permission to change the value. Works fine now. No need for any action.

[stutteringp0et]

@mbabker - when will this make it into the 4.0-dev branch?