Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant CSS - Search module #18277

Merged
merged 1 commit into from
Nov 18, 2017
Merged

Redundant CSS - Search module #18277

merged 1 commit into from
Nov 18, 2017

Conversation

ciar4n
Copy link
Contributor

@ciar4n ciar4n commented Oct 8, 2017

Pull Request for Issue # .

Summary of Changes

Removes redundant search module CSS from Isis template.

@brianteeman Could you confirm for me that this is indeed redundant? Appears to have been part of the navbar.

Testing Instructions

Code review

Expected result

Actual result

Documentation Changes Required

@brianteeman
Copy link
Contributor

yes it would appear to be unused

@ghost
Copy link

ghost commented Oct 28, 2017

I have tested this item ✅ successfully on ca33c0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18277.

@ghost
Copy link

ghost commented Nov 12, 2017

marked as "Easy Test".


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18277.

@csthomas
Copy link
Contributor

I have tested this item ✅ successfully on ca33c0a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18277.

@ghost
Copy link

ghost commented Nov 14, 2017

RTC after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 14, 2017
@mbabker mbabker added this to the Joomla 3.8.3 milestone Nov 18, 2017
@mbabker mbabker merged commit 7f235e0 into joomla:staging Nov 18, 2017
@joomla-cms-bot joomla-cms-bot added PR-staging and removed RTC This Pull Request is Ready To Commit labels Nov 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants