Filesystem namespace #18321
Closed
Filesystem namespace #18321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kill the wrapper classes please :) |
|
I would love to see it against staging or at least 3.9. Can we change the base branch of it? |
|
@laoneo should i close this PR and open a new one? |
|
Whatever feels more comfortable for you. |
|
@fastslack close this PR? This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18321. |
|
@franz-wohlkoenig closed i ll open a new one soon |
|
Need review #18565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Filesystem libs namespacing
Summary of Changes
Move old filesystem libraries to namespace
Testing Instructions
Apply this patch and run Joomla!. Everything should work without issues
Expected result
Actual result
Documentation Changes Required