Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joomla Profile plugin TOS bug #18333

Closed
BjornvanSchie opened this issue Oct 13, 2017 · 9 comments
Closed

Joomla Profile plugin TOS bug #18333

BjornvanSchie opened this issue Oct 13, 2017 · 9 comments

Comments

@BjornvanSchie
Copy link

BjornvanSchie commented Oct 13, 2017

Steps to reproduce the issue

  • Install Usergroup Selector (http://function90.com/products/usergroup-selector.html)
  • Enable Usergroup Selector and select some groups at the "Allowed User Groups" field.
  • Enable Joomla User - Profiles and require TOS and select TOS article
  • Register a user from frontend with a group

Expected result

User will be created with the selected group/groups.

Actual result

User created, but without groups. This is because the JUser->save() is returning false. While further investigating the problem. its telling me the error using the following:
$juser->getError();
This is the result i got: Please read the Terms of Service. You will not be able to register if you do not agree with them.

(these snippets are found in the onUserAfterSave function within the plugin)

My guess is that there is a issue with the User-Profile plugin from joomla. since everything is going fine when i haven't got a TOS Article selected.

System information (as much as possible)

Problem accours on the the following platforms:

  • Windows 10 running latest version of Xampp
  • MacOS running latest version of Mamp pro
  • Ubuntu running webmin with apache2 server

All the instances are running a clean setup of joomla 3.8.1

Additional comments

Teamviewer is possible if needed, also remote joomla login is do-able.

@brianteeman
Copy link
Contributor

I dont have any problem using the TOS option with the core of joomla so the issue must be with the extension. Checking the extension web site i can see that they have problems when you have custom fields enabled as well. Please contact them directly for support.

Closed as not a core issue

@brianteeman
Copy link
Contributor

Also check their site for the other people reporting issues with that plugin and tos
http://function90.com/support/usergroup-selector/343-it-is-not-working-on-my-joomla-3-6-site.html

@coolcat-creations
Copy link
Contributor

coolcat-creations commented Nov 14, 2017

I confirm that there is a bug executing user plugins if a tos article is selected. If no article is selected everything works fine. Can we reopen this issue @brianteeman ?

EDIT: A quick workaround is to leave the Tos Article empty and to include the link to the TOS in the language .ini file into the label of the TOS PLG_USER_PROFILE_FIELD_TOS_LABEL. Not beautiful but it works.

@joomla-cms-bot
Copy link

Set to "open" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/18333

@ghost
Copy link

ghost commented Nov 14, 2017

reopened as stated above.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18333.

@Quy
Copy link
Contributor

Quy commented Feb 11, 2018

@coolcat-creations Please confirm that PR #19633 fixes this issue. Thanks.

@Quy
Copy link
Contributor

Quy commented Feb 11, 2018

@BjornvanSchie You marked #19633 tested successfully. If this is fixed, please close this issue. Thanks.

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/18333

@Quy
Copy link
Contributor

Quy commented Feb 13, 2018

Closing as #19633 has merged. This can be reopened if still an issue.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18333.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants