-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Frontend Filtering by author broken in modal when inserting article via xtd #18445
Conversation
I have tested this item ✅ successfully on b81f778 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18445. |
1 similar comment
I have tested this item ✅ successfully on b81f778 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18445. |
RTC after two successful tests. |
As the null value is -select author- shouldnt the new string be "no author" This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18445. |
used the same string value as in backend when choosing ‘- No User -‘ in the modal. no need to change imho to be consequent. |
I also think that whoever chose the term ‘user’ understood it is selecting a user as author. the result being a user name or none. |
Means this label shows every article that has no author? When does that happen? |
When you edit an article in backend you can select a user as author. The modal lets you chose No User. @brianteeman If you prefer |
I just tested it, and it does not work. If i click at "No user" the article gets reasigned to Superuser. (not related to this PR) So it's not possible to show articles that have no user assigned because there is always an author. Edit: Correction: If i create a new article and select No User it gets assigned to Super User anyway, just when i open it again and remove the user the autor is gone. |
@infograf768 i agree with JNONE and a new pr for that |
@infograf768 i agree with JNONE and a new pr for that will do as well asanother improvement for the managers |
@coolcat-creations |
Pull Request for Issue #18442
Summary of Changes
As the modal uses multiple, the filter_articles xml in frontend has also to use that.
Is also added here the possibility to filter by
No User
as in #18440Testing Instructions
See #18442
Expected result
No more 500 or PHP Warning. Filtering works OK after patch.
@brianteeman
After patch