Mobile views: modals created by xtd plugins show only partially

[infograf768]

For mobiles view < 800x 600 (same for 728 x 1024), the xtd plugins modals (article, menu, contact, image, field) are cut off and there is no way to close their display.

Example here for 600 x800 and xtd-article

(it is worse at smaller sizes)

Tested with Firefox View Responsive Layouts tool.

[dgrammatiko]

@infograf768 is this a tinyMCE triggered modal?

[infograf768]

My tests indeed were done with TinyMCE. If I use Codemirror the modal adapts itself to the window and displays a close button

EDIT: we lose the Search Filters in CodeMirror

[dgrammatiko]

we lose the Search Filters in CodeMirror

It's designed that way, the button hides in smaller screens

Pretty sure I've fixed it in J4 for media field:

joomla-cms/media/editors/tinymce/js/plugins/media/media.js

Lines 13 to 14 in f34dac1

	width : parent.document.body.getBoundingClientRect().width - 50,
	height : (window.innerHeight - 100),

Not so sure that we can apply this in J3 (we're still got mootools for those buttons :( )

[C-Lodder]

TinyMCE use JS to apply a fixed width to the modal.

In J4, the modal doesn't overlap, but instead is a small box which simply isn't big enough.

[dgrammatiko]

@C-Lodder there is a PR for that: #17906

[infograf768]

@dgt41
#17906 does not solve the issue here.

[dgrammatiko]

Is this J3 or J4 issue?

[Quy]

@dgt41 Judging from the screenshots, it appears to be J3.

[infograf768]

J3 indeed

[dgrammatiko]

This one might be tricky to patch, I’ll try some idea later on today

[ghost]

@dgt41 any Progress on this?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18447.}

[twister65]

When you click any button on the TinyMCE toolbar, all popup (modal) windows are not responsive.
To avoid this problem, you need to put your xtd buttons below the editor like other editors (CodeMirror, JCE, ...), I fixed it by calling displayButtons instead of tinyButtons :
https://github.com/twister65/joomla-cms/blob/xtd-btns/plugins/editors/tinymce/tinymce.php

[mbabker]

To avoid this problem, you need to put your xtd buttons below the editor like other editors (CodeMirror, JCE, ...), I fixed it by calling displayButtons instead of tinyButtons

That's not happening. It was a deliberate decision to integrate the extended buttons (xtd plugin group) into TinyMCE as "native" buttons instead of the disconnected buttons below the editor.

[twister65]

TinyMCE 5 incoming, which is responsive: https://www.tiny.cloud/developer-preview/
Adaptive mobile and tablet support.

We rewrote TinyMCE's UI components (toolbars, menus, buttons, etc) to use CSS Flexbox, SVG, and other modern technologies.

[C-Lodder]

@twister65 Can't be used in J3 as it doesn't support IE8

[twister65]

I am disappointed about this:

Since TinyMCE version 4.6.0 Internet Explorer 8-10 is not supported, if you need legacy browser support, the 4.5.X branch is maintained with critical fixes.
https://www.tiny.cloud/docs-preview/general-configuration-guide/system-requirements/#browsercompatibility

[twister65]

I'm embarrassed, because if I take a picture, and want to add it to my site with my phone, then I can not.
I guess a lot of people have to be in that same situation.
We can not change an article when we are traveling (vacation, business trip, ...).

[twister65]

That's why this issue interests me because I already had it.
Does anyone have a solution ?
Can not we adapt the tinyMCE source code for Joomla ?

[mbabker]

We're not forking the editor to be able to upgrade it and retain IE8 support. How TinyMCE support looks in J4 (where it is using a TinyMCE 4.7 release last I was aware) is another story.

[twister65]

Perhaps, using TinyMCE in a Bootstrap Dialog.
https://www.tiny.cloud/docs/integrations/bootstrap/#usingtinymceinabootstrapdialog
Look at this example, the modal seems to be responsive :
http://fiddle.tinymce.com/oxdaab

[dgrammatiko]

@twister65 in a Bootstrap Dialog? Really? What will be the benefit of hiding the editor and then force a user to open a modal to interact with the editor? I will not even bother to comment on the Bootstrap Dialog...

Not to mention that your proposal is not fixing something:

[twister65]

IE8 ? Really? Who still uses such a browser ?
https://www.w3schools.com/browsers/browsers_explorer.asp
http://gs.statcounter.com/browser-version-market-share

I can't see it in the Joomla v3.x requirements :
https://downloads.joomla.org/technical-requirements

[C-Lodder]

@twister65 https://docs.joomla.org/Joomla_Browser_Support

That applies to J3, not J4

[twister65]

@C-Lodder and Netscape ;-)
Have you seen the statistics ? Less than 0.2% for old IEs.
When we log in as an administrator in Joomla, we have a php warning:

Warning
Your PHP version, 5.6.34, is only receiving security fixes from the PHP project at this time. This means your PHP version will soon no longer be supported. We recommend planning to upgrade to a newer PHP version before it reaches end of support on 2018-12-31. Joomla will be faster and more secure if you upgrade to a newer PHP version. Please contact your host for upgrade instructions.

Despite the requirements of Joomla:

PHP | 5.6 or 7.0 + (Recommended) | 5.3.10 (Minimum).

Why not for browsers ?

[twister65]

Support for older versions of Internet Explorer ended.
Beginning January 12, 2016, only the most current version of Internet Explorer available for a supported operating system will receive technical supports and security updates.

https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support

[C-Lodder]

@twister65 Yes I'm aware of the stats. The fact being is that Joomla must continue support for IE8 in the 3.x series as it's follows sematic versioning. Dropping support for a major browser version such as IE8 will require a major Joomla updates, thus Joomla 4.

PHP versions are completely different from browser versions and are not related in the slightest.

Let's take a handful of sites, for example 1 million, that are running Joomla on PHP 5.3 and 500k of those users have other websites using perhaps a custom framework, cms, etc etc that was written for PHP 5.3. Let's then say that Joomla decided to stop supporting PHP 5.3 in 3.10. Those 1 millions websites then get updated from Joomla 3.9 to 3.10 the day it's released (wouldn't that be lovely). Those 1 million users then notice errors being thrown all over the place on their sites. They then notice they have to update their PHP version to 7.x and proceed to doing so.
The other 500k users that have other PHP 5.3 applications on their servers then notice errors and find they don't have the time, money, or resources to migrate what could potentially be a huge system.
Times that scale by 10 and you'll most likely have each company voting for JEXIT

Besides, the message you see is purely a warning. Joomla 3 still supports PHP 5.3.10 and will not break that. Recommended and minimum requires are again, 2 very different things.

[twister65]

You can close this issue. See PR #23091.

[infograf768]

Closing.