Fix Undefined index: JHtmlBootstrap::startAccordion / JHtmlBootstrap::startTabSet

[Quy]

Pull Request for Issue #17853.

Summary of Changes

Contact links section does not have the accordion/tab initialization code so when it is the first section to display, the slide/tab cannot be added to.

Testing Instructions

Install Test English Sample Data demo.
Enable Maximum for Error Reporting.
Under Configuration > Contacts > Contact, set Contact Information to hide.
On front end, click Featured Contacts.
Click Shop Address contact.

Expected result

No notice warnings.

Actual result

Notice: Undefined index: JHtmlBootstrap::startAccordion in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 693

Notice: Undefined index: JHtmlBootstrap::startAccordion in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 694

Notice: Undefined index: JHtmlBootstrap::startAccordion in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 695

or

Notice: Undefined index: JHtmlBootstrap::startTabSet in C:\xampp\htdocs\joomla-cms\libraries\cms\html\bootstrap.php on line 788

Documentation Changes Required

None

[C-Lodder]

If the following doesn't cause any errors, it should be used instead:

<?php if ($presentation_style === 'sliders') : ?>
	<?php if (!$accordionStarted) : ?>
		<?php echo JHtml::_('bootstrap.startAccordion', 'slide-contact', array('active' => 'display-links')); ?>
		<?php $accordionStarted = true; ?>
	<?php endif; ?>
<?php elseif ($presentation_style === 'tabs') : ?>
	<?php if (!$tabSetStarted) : ?>
		<?php echo JHtml::_('bootstrap.startTabSet', 'myTab', array('active' => 'display-links')); ?>
		<?php $tabSetStarted = true;  ?>
	<?php endif; ?>
<?php endif; ?>

[ladyjer]

I have tested this item ✅ successfully on 5a06904

@C-Lodder version works too. CS with ':' should be preferred, but CS with '{' is used everywhere in default.php for second level if statements.
I don't know which one is then best.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18573.}

[ladyjer]

@C-Lodder version works too. CS with ':' should be preferred, but CS with '{' is used in this default.php for every second level if.
I don't know which one of the two is the best.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18573.}

[Quy]

Per Joomla's Coding Standards, read Mixed language usage (e.g. at the layout files). Be sure to scroll up a little bit.

[Quy]

@franz-wohlkoenig can you test please?

[ghost]

I have tested this item ✅ successfully on 5a06904

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/18573.}

[ghost]

Ready to Commit after two successful tests.