Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] uninstalling a file extension does not trigger manifest script #19085

Closed
avjoomla opened this issue Dec 16, 2017 · 5 comments
Closed

[4.0] uninstalling a file extension does not trigger manifest script #19085

avjoomla opened this issue Dec 16, 2017 · 5 comments

Comments

@avjoomla
Copy link
Contributor

avjoomla commented Dec 16, 2017

Steps to reproduce the issue

Install a file extension that includes a script file with in manifest xml. Scriptfile should have a postflight, preflight or unistall method with some custom code. Unistall the extension.
I necessary, I could create a very small test installation zip for you.

Expected result

preflight, uninstall and postflight methods in manifest script (script.php) are executed

Actual result

Non of the methods is executed but script file is deleted properly

System information (as much as possible)

Joomla! 4.0.0-dev Development [ Amani ] 19-November-2017 16:34 GMT
Local XAMPP Apache/2.4.26 (Win32) OpenSSL/1.0.2l PHP/7.1.7 on Windows 7

Additional comments

This ussue only happens on uninstall. Install works fine.
I think basically the problem is, that the getElement() function in the FileAdapter class tries to locate the script file with
$manifestPath = \JPath::clean($this->parent->getPath('manifest'));
but this path is not set at any time for the FileAdapter
On other adpaters (like PackageAdapter, PluginAdapter this issue does not happen, too).

@joomla-cms-bot joomla-cms-bot changed the title Joomla! 4 uninstalling a file extension does not trigger manifest script [4.0] uninstalling a file extension does not trigger manifest script Dec 16, 2017
@brianteeman
Copy link
Contributor

Just to confirm that this works on J3 ??

@avjoomla
Copy link
Contributor Author

Yes, tested with Joomla! 3.8.3

@ghost
Copy link

ghost commented Apr 2, 2019

@avjoomla can you please test if this Issue is resolved?

@avjoomla
Copy link
Contributor Author

avjoomla commented Jul 29, 2019

Hi,
no it is not.
Regards,
Aicha

@Hackwar
Copy link
Member

Hackwar commented Nov 8, 2022

#39180 should fix this. Please test that PR. Closing this issue.

@Hackwar Hackwar closed this as completed Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

No branches or pull requests

4 participants