Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Password Strength Bar Width is 100%. #19227

Closed
chetanmadaan opened this issue Dec 29, 2017 · 12 comments
Closed

[4.0] Password Strength Bar Width is 100%. #19227

chetanmadaan opened this issue Dec 29, 2017 · 12 comments

Comments

@chetanmadaan
Copy link

chetanmadaan commented Dec 29, 2017

Steps to reproduce the issue

Go to Joomla backend > User Manager >> New User
You can see the Password Strength Bar is 100% wide.

Expected result

It should just be as wide as the field itself.

Actual result

image

System information (as much as possible)

Joomla 4.0.0-dev

Additional comments

PHP 7

@ghost
Copy link

ghost commented Dec 30, 2017

Issue confirmed.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19227.

@anuragteapot
Copy link
Contributor

change build to 4.0-dev


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19227.

@ghost
Copy link

ghost commented Dec 30, 2017

@Anu1601CS done, thanks for Hint.

@S2606
Copy link

S2606 commented Jan 2, 2018

can i work in this??


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19227.

@dgrammatiko
Copy link
Contributor

@S2606 sure, just make a pr against #19231

@dgrammatiko
Copy link
Contributor

Actually this is solved with #19231

@anuragteapot
Copy link
Contributor

@dgt41 I have tested this on pr #19231 this issue is still present.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19227.

@amone4
Copy link
Contributor

amone4 commented Mar 21, 2018

I did manage to solve this bug, by appending some code to passwordstrength.js (passwordstrength.min.js), in an installed version of the CMS. But the file I modified is quite different than what I found after cloning the repository https://github.com/joomla/joomla-cms

I wanted to ask how the above file is being generated. The version that I installed was from https://www.joomla.org/announcements/release-news/5718-joomla-4-0-alpha-1-release.html


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19227.

@dgrammatiko
Copy link
Contributor

@amone4 please do a PR against #19231. The passwordstrength.min.js is going to be removed

@anuragteapot
Copy link
Contributor

anuragteapot commented Mar 21, 2018

@amone4 clone the latest dev from here https://github.com/joomla/joomla-cms/tree/4.0-dev
And make PR against #19231

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/19227

@Quy
Copy link
Contributor

Quy commented May 20, 2018

Fixed in PR #19231


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19227.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants