-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Use namespaced classes for layouts [Part 6] #19254
Conversation
> | ||
<span class="icon-eye" aria-hidden="true"></span> <?php echo JText::_('PLG_TINY_BUTTON_TOGGLE_EDITOR'); ?> | ||
<span class="icon-eye" aria-hidden="true"></span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use fa
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I'll do all that in another PR. Only did a few as I was going along
layouts/joomla/tinymce/buttons.php
Outdated
@@ -9,5 +9,8 @@ | |||
|
|||
defined('JPATH_BASE') or die; | |||
|
|||
JLog::add('The layout joomla.tinymce.buttons is deprecated, use joomla.editors.buttons instead.', JLog::WARNING, 'deprecated'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kill this file
@@ -9,5 +9,8 @@ | |||
|
|||
defined('JPATH_BASE') or die; | |||
|
|||
JLog::add('The layout joomla.tinymce.buttons.button is deprecated, use joomla.editors.buttons.button instead.', JLog::WARNING, 'deprecated'); | |||
echo JLayoutHelper::render('joomla.editors.buttons.button', $displayData); | |||
use Joomla\CMS\Layout\LayoutHelper; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And this one
Summary of Changes
Use namespaced classes for:
layouts/joomla/html/**
layouts/joomla/sidebars/**
layouts/joomla/system/**
layouts/joomla/tinymce/**
Testing Instructions
code review