Adding a Honeypot Field Plugin to the Captcha Options #19286

coolcat-creations · 2018-01-04T11:58:22Z

Summary of Changes

Altough Honeypot is not really a "captcha" functionality I think it fits best in the captcha plugin group. This plugin creates a hidden field named "repeatmail". The field name can be changed by the user. If repeatmail is filled, the form can't be sent.

Testing Instructions

Enable the Honeypot in the Captcha Options in your main configuration.

Use the Contactform and send a mail -> everything should work as before
Use element inspector to disable the StyleDeclaration that hides the field and fill the field, try to send the form, an error should appear.

Documentation Changes Required

Yes, as it's a new feature

brianteeman · 2018-01-04T12:13:15Z

Personally I dont see the need to add this to the core

coolcat-creations · 2018-01-04T12:15:38Z

Google Captcha v1 and v2 are outdated and the new "invisible recaptcha" creates a always visible google flag. I think a honeypot solution is much more userfriendly and does not display large flags like this in the page corner:

brianteeman · 2018-01-04T12:32:21Z

plugins/captcha/honeypot/honeypot.php

+	 *
+	 * @return  string  The HTML to be embedded in the form.
+	 *
+	 * @since  2.5


DEPLOY_VERSION

brianteeman · 2018-01-04T12:32:51Z

plugins/captcha/honeypot/honeypot.php

+	 *
+	 * @return  True if the answer is correct, false otherwise
+	 *
+	 * @since  2.5


DEPLOY_VERSION

brianteeman · 2018-01-04T12:33:33Z

plugins/captcha/honeypot/honeypot.xml

+			<fieldset name="basic">
+
+				<field
+						name="fieldname"


one tab too many here

name, type, label description

brianteeman · 2018-01-04T12:41:36Z

plugins/captcha/honeypot/honeypot.php

@@ -24,7 +24,7 @@ class PlgCaptchaHoneypot extends JPlugin
 	 *
 	 * @return  string  The HTML to be embedded in the form.
 	 *
-	 * @since  2.5
+	 * @since  3.9


sorry you misunderstood me - this should not be a version number but the string _DEPLOY_VERSION_

brianteeman · 2018-01-04T12:42:42Z

plugins/captcha/honeypot/honeypot.xml

-						description="PLG_CAPTCHA_HONEYPOT_FIELDNAME_DESC"
-						type="text"
-						default="repeatmail"
+					name="fieldname"


you missed the second comment about the ordering - it should be
name, type, label, description

Quy · 2018-01-04T16:04:43Z

plugins/captcha/honeypot/honeypot.php

+	 *
+	 * @return  True if the answer is correct, false otherwise
+	 *
+	 * @since  _DEPLOY_VERSION_


2 underscores __DEPLOY_VERSION__

Quy · 2018-01-04T16:05:02Z

plugins/captcha/honeypot/honeypot.php

+	 *
+	 * @return  string  The HTML to be embedded in the form.
+	 *
+	 * @since  _DEPLOY_VERSION_


2 underscores __DEPLOY_VERSION__

Quy · 2018-01-04T16:05:55Z

plugins/captcha/honeypot/honeypot.php

+		}
+
+		return true;
+


Remove blank line

Quy · 2018-01-04T16:06:13Z

plugins/captcha/honeypot/honeypot.php

+	/**
+	 * Verifies if the honeypot field is empty
+	 *
+	 * @param   string  $code  Answer provided by user.


Change to $response

Quy · 2018-01-04T16:07:44Z

plugins/captcha/honeypot/honeypot.php

+	public function onDisplay()
+	{
+		$doc = JFactory::getDocument();
+/*		$doc->addStyleDeclaration('body label[for="' . $this->params->get("fieldname")  . '"], body label[for="jform_captcha"], body label[for="jform_captcha"] + span.optional, body #' . $this->params->get("fieldname")  . ' {display: none;  visibility: hidden; }');*/


Quy · 2018-01-04T16:07:56Z

plugins/captcha/honeypot/honeypot.php

+	{
+		$doc = JFactory::getDocument();
+/*		$doc->addStyleDeclaration('body label[for="' . $this->params->get("fieldname")  . '"], body label[for="jform_captcha"], body label[for="jform_captcha"] + span.optional, body #' . $this->params->get("fieldname")  . ' {display: none;  visibility: hidden; }');*/
+		return '<input id="' . $this->params->get("fieldname")  . '" name="' . $this->params->get("fieldname")  . '" size="40" type="text" autocomplete="false" autofill="off" />';


Add a blank line above

Quy · 2018-01-04T16:09:08Z

plugins/captcha/honeypot/honeypot.php

+		return true;
+
+	}
+


Remove blank line

Quy · 2018-01-04T16:09:19Z

plugins/captcha/honeypot/honeypot.php

+
+class PlgCaptchaHoneypot extends JPlugin
+{
+


Remove blank line

brianteeman · 2018-01-04T16:33:06Z

Why do you allow the field name to be changed? Remember that as the field is only hidden from sighted users so in order for this to work as intended the fieldname must be something that a user of assistive technology would not think they need to complete,

C-Lodder · 2018-01-05T10:31:24Z

plugins/captcha/honeypot/honeypot.php

+	public function onDisplay()
+	{
+		$doc = JFactory::getDocument();
+/*		$doc->addStyleDeclaration('body label[for="' . $this->params->get("fieldname")  . '"], body label[for="jform_captcha"], body label[for="jform_captcha"] + span.optional, body #' . $this->params->get("fieldname")  . ' {display: none;  visibility: hidden; }');*/


Remove body from the scope in the CSS

coolcat-creations · 2018-01-06T08:50:08Z

@C-Lodder the body scope was on purpose to enforce hiding the label without using an important. I mean when any 3rd Party Template would have a style for that. What do you think, should I really remove the scope?

coolcat-creations · 2018-01-06T08:54:14Z

@brianteeman thought i would keep it flexible when allowing to change the fieldname so if someone woukd have a repeatmail field for real the conflict could be resolved. How to tell screenreaders that this field is not important i will investigate.

brianteeman · 2018-01-06T09:33:03Z

. How to tell screenreaders that this field is not important i will investigate.

As far as I am aware that is not possible

coolcat-creations · 2018-01-11T10:45:30Z

I got some more feedback outside this PR and want to put it on hold for a few weeks until I have the time to implement all suggestions. Thanks for reviewing to everyone.

coolcat-creations · 2018-04-05T12:31:50Z

I searched for different possibilities to make the Honeypot - really - accessible but i did not found a method. I think we need something in core that is Google-Independant - but i have no idea what. Closing this for now.

Initial commit

b930d61

joomla-cms-bot added Language Change This is for Translators PR-staging labels Jan 4, 2018

coolcat-creations added 2 commits January 4, 2018 13:00

Override the files

6b2e037

Disable Autofill Options

800b29b

brianteeman added the Feature label Jan 4, 2018

brianteeman reviewed Jan 4, 2018

View reviewed changes

Fix reviewed issues

8581934

brianteeman reviewed Jan 4, 2018

View reviewed changes

Fix errors

3f1dcde

Quy reviewed Jan 4, 2018

View reviewed changes

plugins/captcha/honeypot/honeypot.php

}

return true;

Copy link

Contributor

Quy Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line

Quy reviewed Jan 4, 2018

View reviewed changes

plugins/captcha/honeypot/honeypot.php

return true;

}

Copy link

Contributor

Quy Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line

Quy reviewed Jan 4, 2018

View reviewed changes

plugins/captcha/honeypot/honeypot.php

class PlgCaptchaHoneypot extends JPlugin

{

Copy link

Contributor

Quy Jan 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove blank line

C-Lodder reviewed Jan 5, 2018

View reviewed changes

coolcat-creations closed this Apr 5, 2018

coolcat-creations mentioned this pull request Sep 8, 2018

Is there a way to disable or hook in invisible recaptcha for GEO IP China? #22063

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a Honeypot Field Plugin to the Captcha Options #19286

Adding a Honeypot Field Plugin to the Captcha Options #19286

coolcat-creations commented Jan 4, 2018 •

edited

brianteeman commented Jan 4, 2018

coolcat-creations commented Jan 4, 2018

brianteeman Jan 4, 2018

brianteeman Jan 4, 2018

brianteeman Jan 4, 2018

brianteeman Jan 4, 2018

brianteeman Jan 4, 2018

coolcat-creations Jan 4, 2018

brianteeman Jan 4, 2018

coolcat-creations Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

Quy Jan 4, 2018

brianteeman commented Jan 4, 2018

C-Lodder Jan 5, 2018

coolcat-creations commented Jan 6, 2018

coolcat-creations commented Jan 6, 2018

brianteeman commented Jan 6, 2018

coolcat-creations commented Jan 11, 2018

coolcat-creations commented Apr 5, 2018

Adding a Honeypot Field Plugin to the Captcha Options #19286

Adding a Honeypot Field Plugin to the Captcha Options #19286

Conversation

coolcat-creations commented Jan 4, 2018 • edited

Summary of Changes

Testing Instructions

Documentation Changes Required

brianteeman commented Jan 4, 2018

coolcat-creations commented Jan 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brianteeman commented Jan 4, 2018

Choose a reason for hiding this comment

coolcat-creations commented Jan 6, 2018

coolcat-creations commented Jan 6, 2018

brianteeman commented Jan 6, 2018

coolcat-creations commented Jan 11, 2018

coolcat-creations commented Apr 5, 2018

coolcat-creations commented Jan 4, 2018 •

edited