[4.0] Split the rules field to 2 layouts #19507
Conversation
|
Removed ACL tooltips due to remove in base branch. |
|
Thanks! |
|
@wilsonge Thanks :) |
|
Why was that Jlayout placed into |
|
@Bakual yeah, you are right. |
|
Thanks. I'll move it then in my PR 😄 |
|
@Bakual Thanks |
| * @var boolean $hasValue Has this field a value assigned? | ||
| * @var array $options Options available for this field. | ||
| * | ||
| * Calendar Specific |
There was a problem hiding this comment.
Please make a PR to correct the variables used here
There was a problem hiding this comment.
should I remove JLayout variables which were not used in this file?
| * Name of the layout being used to render the field | ||
| * | ||
| * @var string | ||
| * @since 3.5 |
There was a problem hiding this comment.
since not 3.5 but __DEPLOY_VERSION__
| * | ||
| * @return array | ||
| * | ||
| * @since 3.5 |
There was a problem hiding this comment.
since not 3.5 but __DEPLOY_VERSION__
| 'assetRules' => $this->assetRules, | ||
| 'isGlobalConfig' => $this->isGlobalConfig, | ||
| 'parentAssetId' => $this->parentAssetId, | ||
| ); |
There was a problem hiding this comment.
All these variables need to be explained in the doc block of the JLayout
|
@Anu1601CS Please check my comments here and please make a PR to correct the doc blocks. Thanks |
|
@dgt41 Thanks for review PR coming soon. |
Summary of Changes
Splits the HTML part (JLayout) into two files.
Reasons:
1: less code per file
2: more efficient caching (less allocate memory, etc)
Testing Instructions
1: Apply patch
2: Go to Admin->Global Configuration
3: Check Permissions working as before
Expected result
This is code improvement
Actual result
Same as before
Documentation Changes Required
Yes