Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homepage pagination does not add other parameters #19579

Closed
ztj1993 opened this issue Feb 6, 2018 · 9 comments
Closed

Homepage pagination does not add other parameters #19579

ztj1993 opened this issue Feb 6, 2018 · 9 comments

Comments

@ztj1993
Copy link

ztj1993 commented Feb 6, 2018

Today in the development, found that the home page can not add other parameters!

Desired results:
http://domain/?aaa=1
http://domain/?aaa=1&start=10
http://domain/?aaa=1&start=20

The result of the present:
http://domain/?aaa=1
http://domain/?start=10
http://domain/?start=20

Should it be like this?

The above content for software translation!

@zero-24
Copy link
Contributor

zero-24 commented Feb 6, 2018

@ztj1993 can you please try the latest rc version https://github.com/joomla/joomla-cms/releases/tag/3.8.5-rc? As this release contains patches to be released stable today.

@ztj1993
Copy link
Author

ztj1993 commented Feb 6, 2018

@zero-24 OK, I'm doing more tests, as if this was just the case on the front page, and the other menu pages wouldn't have happened that way.

@ztj1993
Copy link
Author

ztj1993 commented Feb 6, 2018

@zero-24 It is true that the test does not appear on the front page.

@ztj1993 ztj1993 changed the title New versions cause pagination to not add other parameters Homepage pagination does not add other parameters Feb 6, 2018
@zero-24
Copy link
Contributor

zero-24 commented Feb 6, 2018

@ztj1993 can you please clarify what you mean? Did the 3.8.5-rc package fixed the problem or not?

@ztj1993
Copy link
Author

ztj1993 commented Feb 6, 2018

@zero-24 The effect of this problem is not very big now, only a few special cases will be used.

To implement the problem steps:
Please open this page: http://www.portablecn.com/?aa=1
Please pay attention to the URL parameter AA; then click on the next page to see that the AA parameter does not exist.

If the first page to do filtering, this problem will have an impact!

The above content for software translation!

@ggppdk
Copy link
Contributor

ggppdk commented Feb 6, 2018

i have seen this bug, and added a workaround in our pagination code,

When the paginated page is the home page then all URL variables that do not exist in the home page page menu item are lost, thus you can not e.g. paginate a filtered view

The bug is in SiteRouter.php

@brianteeman
Copy link
Contributor

Why do you write "workarounds" instead of fixing the issue upstream and help everyone?

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/19579

@ghost
Copy link

ghost commented Feb 6, 2018

closed as having Pull Request #19582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants