REGRESSION User profile plugin #19614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the User - Joomla plugin and set the first field to be required Enable user registration Try to register a user on the front end and you will see that field Address 1 is displayed as optional - it should be displayed as required. Try to register without completing field Address 1 and it will fail saying that Address 1 is required This has been a long standing recurring bug. This instance has come from Fix form data lost when user registration failed joomla#19145 Reverting that PR resolves this issue but then of course it means that the issue being fixed in joomla#19145 had returned
|
This "bug" keeps re-occurring. Its been fixed so many times as so many different things keep breaking the display of "required" here. Should there not be a unit test to ensure that the field is displayed as optional/required and then seemingly unrelated changes wont keep breaking this. @rdeutz |
|
I think we can fix both issues, please consider testing PR #19617
you meant User - Profile plugin, right ? |
|
I have tested this item ✅ successfully on c4497ce This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19614. |
|
I have not tested this item. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/19614. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the User - Joomla plugin and set the first field to be required
Enable user registration
Try to register a user on the front end and you will see that field Address 1 is displayed as optional - it should be displayed as required.
Try to register without completing field Address 1 and it will fail saying that Address 1 is required
This has been a long standing recurring bug. This instance has come from
Fix form data lost when user registration failed #19145
Reverting that PR resolves this issue but then of course it means that the issue being fixed in #19145 had returned