[4.0] Fix the web components #19957
Merged
[4.0] Fix the web components #19957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
The method
HTMLHelper::webcomponent()is a little different than the script or stylesheet. This PR aligns it (basically the first param was an array and now is just the script path to be included).This also assures that web components won't get loaded multiple times!
Testing Instructions
Apply patch, go to the backend and observe that alerts, switcher, media field and user field are still working!
Expected result
Actual result
Documentation Changes Required
Yes, a note here, using the same params as script and stylesheet is a good thing and also helpful for all devs since they don't have to remember that this method is weird and needs something different.
@wilsonge this is essential, I've got it wrong here 馃槗