Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show_profile option #20021

Merged
merged 2 commits into from
May 28, 2018
Merged

show_profile option #20021

merged 2 commits into from
May 28, 2018

Conversation

eshiol
Copy link
Contributor

@eshiol eshiol commented Mar 29, 2018

Summary of Changes

Added the option show user profile to the contacts > single contact menu item.

Testing Instructions

Create a new contats > single contact menu item
Go to the Contact Display Option

Expected result

image

Actual result

The option doesn't exists

Documentation Changes Required

@Quy
Copy link
Contributor

Quy commented Mar 30, 2018

This option should be disabled/hidden if Profile plugin is disabled.

@eshiol
Copy link
Contributor Author

eshiol commented Mar 30, 2018

In the Contacts options page the option User Profile is always visible. What about to add a new attribute dependencies to the fields?

			<field 
				name="show_profile" 
				type="list"
				label="COM_CONTACT_FIELD_PROFILE_SHOW_LABEL"
				description="COM_CONTACT_FIELD_PROFILE_SHOW_DESC"
				useglobal="true"
				class="chzn-color"
				dependencies="plg_user_profile"
				>
				<option value="0">JHIDE</option>
				<option value="1">JSHOW</option>
			</field>

@inolibero
Copy link

I have tested this item ✅ successfully on f254a10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20021.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on f254a10


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20021.

@Quy
Copy link
Contributor

Quy commented May 8, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20021.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 8, 2018
@mbabker mbabker added this to the Joomla 3.9.0 milestone May 10, 2018
@mbabker mbabker changed the base branch from staging to 3.9-dev May 28, 2018 14:59
@mbabker mbabker merged commit 594f5dd into joomla:3.9-dev May 28, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants