Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Email cloak unittests are failing on 4.0 #20054

Closed
zero-24 opened this issue Apr 1, 2018 · 9 comments
Closed

[4.0] Email cloak unittests are failing on 4.0 #20054

zero-24 opened this issue Apr 1, 2018 · 9 comments

Comments

@zero-24
Copy link
Contributor

zero-24 commented Apr 1, 2018

Steps to reproduce the issue

http://ci.joomla.org/joomla/joomla-cms/4269/12

Expected result

Drone works

Actual result

Drone fails on 4.0-dev unittests

System information (as much as possible)

After the merge of:
#19089 ([4.0] email cloaking without inline script)
#20053 (correction to the webcomponent call)

Additional comments

cc @wilsonge @dgt41

I have no quick idea what is wrong here :(

@dgrammatiko
Copy link
Contributor

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 1, 2018

Here is a PR: joomla/test-unit#1

But to me that should not produce a Exception: Failed to start application error i would just expect a failed test.

@dgrammatiko
Copy link
Contributor

@zero-24 can you restart drone?

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 1, 2018

Just done http://ci.joomla.org/joomla/joomla-cms/4273/10 lets see what happens.

@dgrammatiko
Copy link
Contributor

dgrammatiko commented Apr 1, 2018

@zero-24 it needs a bit more I think: joomla/test-unit#2

BTW: cannot marge my own PR, so @wilsonge

@zero-24
Copy link
Contributor Author

zero-24 commented Apr 1, 2018

I have no access to that repo to merge too :(

@dgrammatiko
Copy link
Contributor

give me 5 secs the PR is not correct

@rdeutz
Copy link
Contributor

rdeutz commented Apr 2, 2018

it is merged and I tagged the repo so that it will be used

@rdeutz
Copy link
Contributor

rdeutz commented Apr 2, 2018

I will close it because I fixed it, with a couple of commits. For the record:

JHtmlEmail has now a dependency to HTMLHelper::webcomponet and this has a hardcoded dependency to Factory. So the falling test is no longer a Unit test and I removed the test.

@rdeutz rdeutz closed this as completed Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants