-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Email cloak unittests are failing on 4.0 #20054
Comments
The test file should be updated here: https://github.com/joomla/test-unit/blob/master/suites/libraries/cms/html/JHtmlEmailTest.php |
Here is a PR: joomla/test-unit#1 But to me that should not produce a |
@zero-24 can you restart drone? |
Just done http://ci.joomla.org/joomla/joomla-cms/4273/10 lets see what happens. |
@zero-24 it needs a bit more I think: joomla/test-unit#2 BTW: cannot marge my own PR, so @wilsonge |
I have no access to that repo to merge too :( |
give me 5 secs the PR is not correct |
it is merged and I tagged the repo so that it will be used |
I will close it because I fixed it, with a couple of commits. For the record: JHtmlEmail has now a dependency to HTMLHelper::webcomponet and this has a hardcoded dependency to Factory. So the falling test is no longer a Unit test and I removed the test. |
Steps to reproduce the issue
http://ci.joomla.org/joomla/joomla-cms/4269/12
Expected result
Drone works
Actual result
Drone fails on 4.0-dev unittests
System information (as much as possible)
After the merge of:
#19089 ([4.0] email cloaking without inline script)
#20053 (correction to the webcomponent call)
Additional comments
cc @wilsonge @dgt41
I have no quick idea what is wrong here :(
The text was updated successfully, but these errors were encountered: