Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plg_content_pagebreak] Let users template override TOC #20202

Merged
merged 9 commits into from May 12, 2018
Merged

[plg_content_pagebreak] Let users template override TOC #20202

merged 9 commits into from May 12, 2018

Conversation

ReLater
Copy link
Contributor

@ReLater ReLater commented Apr 19, 2018

See discussion here: #17670

Summary of Changes

  • Added possibility to use a template override for TOC.
  • Don't break B\C.
  • BTW: Fix older bug: "Show All" never has active class even if active.

Testing Instructions

  • Plugin "Content - Page Break". Make settings:

19-04-_2018_19-35-49

  • Add some pagebreak markers to an article and open article in frontend.
  • Inspect TOC (also source code).

19-04-_2018_19-37-41

  • Apply patch.

  • Inspect TOC (also source code).

  • Expected: No changes.

  • Create a template override for new file tmpl/toc.php.
    Example with Protostar:

19-04-_2018_19-43-30

  • Check that the override works.

@dgrammatiko
Copy link
Contributor

we need to make sure that all plugins are actually overridable! Great work here 👍

<?php endif; ?>

<ul class="nav nav-tabs nav-stacked">
<?php foreach ($list as $listItem) :
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change to per Joomla's Coding Standards.

<?php foreach ($list as $listItem) : ?>
        <?php $class = $listItem->liClass ? ' class="' . $listItem->liClass . '"' : ''; ?>

}

$row->toc .= '</ul></div>';

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove tabs

@Quy
Copy link
Contributor

Quy commented Apr 20, 2018

I have tested this item ✅ successfully on 50c8e51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202.

@ReLater ReLater changed the title [RFC] [plg_content_pagebreak] Let users template override TOC [plg_content_pagebreak] Let users template override TOC Apr 21, 2018
@joomla-cms-bot joomla-cms-bot removed the RFC Request for Comment label Apr 21, 2018
@LivioCavallo
Copy link
Contributor

I have tested this item ✅ successfully on 50c8e51


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202.

@LivioCavallo
Copy link
Contributor

LivioCavallo commented Apr 26, 2018

Well done. Thanks. I tested it successfully. If all will be ok I'll close #17670

@joomla-cms-bot joomla-cms-bot added the RFC Request for Comment label Apr 26, 2018
@Quy
Copy link
Contributor

Quy commented Apr 26, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 26, 2018
@mbabker mbabker added this to the Joomla 3.9.0 milestone Apr 29, 2018
@brianteeman brianteeman removed the RFC Request for Comment label May 1, 2018
@mbabker mbabker changed the base branch from staging to 3.9-dev May 12, 2018 17:04
@mbabker mbabker modified the milestones: Joomla 3.10.0, Joomla 3.9.0 May 12, 2018
@mbabker mbabker merged commit 89d7f03 into joomla:3.9-dev May 12, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 12, 2018
@ReLater ReLater deleted the patch-9 branch September 24, 2018 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants