New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[plg_content_pagebreak] Let users template override TOC #20202
Conversation
we need to make sure that all plugins are actually overridable! Great work here 👍 |
<?php endif; ?> | ||
|
||
<ul class="nav nav-tabs nav-stacked"> | ||
<?php foreach ($list as $listItem) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change to per Joomla's Coding Standards.
<?php foreach ($list as $listItem) : ?>
<?php $class = $listItem->liClass ? ' class="' . $listItem->liClass . '"' : ''; ?>
} | ||
|
||
$row->toc .= '</ul></div>'; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove tabs
I have tested this item ✅ successfully on 50c8e51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202. |
I have tested this item ✅ successfully on 50c8e51 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202. |
Well done. Thanks. I tested it successfully. If all will be ok I'll close #17670 |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20202. |
See discussion here: #17670
Summary of Changes
active
class even if active.Testing Instructions
Apply patch.
Inspect TOC (also source code).
Expected: No changes.
Create a template override for new file tmpl/toc.php.
Example with Protostar: