Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switcher parameter style works odd (Joomla 4) #20314

Closed
htmgarcia opened this issue May 7, 2018 · 4 comments
Closed

Switcher parameter style works odd (Joomla 4) #20314

htmgarcia opened this issue May 7, 2018 · 4 comments

Comments

@htmgarcia
Copy link
Contributor

Steps to reproduce the issue

If you are adding a radio parameter using the switcher class (in this case for a template through the file templateDetails.xml)

<field
    name="something"
    type="radio"
    class="switcher"
    default="0"
    label="Something">
        <option value="1">Yes</option>
	<option value="0">No</option>
</field>

Expected result

The switcher should be in gray color when the default value is 0 ("No")
The switcher should be in green color when the default value is 1 ("Yes")

Actual result

The switcher is in green color when the default value is 0 ("No")
screen shot 2018-05-07 at 4 24 55 pm

The switcher is in gray color when the default value is 1 ("Yes")
screen shot 2018-05-07 at 4 25 28 pm

System information (as much as possible)

Chrome Version 66.0.3359.139 (Official Build) (64-bit)
MacOS High Sierra 10.13.4

Additional comments

It seems that the order of the options would make the switcher to works fine:

<option value="0">No</option>
<option value="1">Yes</option>

In the other side, if the options are listed with "1" as first, is when doesn't work:

<option value="1">Yes</option>
<option value="0">No</option>
@htmgarcia htmgarcia changed the title Switcher parameter style works odd Switcher parameter style works odd (Joomla 4) May 7, 2018
@dgrammatiko
Copy link
Contributor

I will try to fix this in joomla/40-backend-template#395

@htmgarcia
Copy link
Contributor Author

Thanks @dgrammatiko !

@htmgarcia
Copy link
Contributor Author

Closing. This issue was already reported joomla/40-backend-template#395 (comment)

@C-Lodder
Copy link
Member

C-Lodder commented May 9, 2018

The normal approach for the Switcher would be (note the order of the options)

<option value="0">No</option>
<option value="1">Yes</option>

This would result in: No (grey) and Yes (green).

If you don't want "Yes" to be green, or is not the recommended setting, you can add a class to the XML field, like so:

<field
    type="radio"
    class="switcher switcher-danger"

You cannot "patch" this simply because it may not always be the case where the user uses the values 0 and 1 or the text No and Yes. They may very well go with:

<option value="foo">Apples</option>
<option value="bar">Pears</option>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants