Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Config Form not reading live Configuration #20588

Closed
PhilETaylor opened this issue May 27, 2018 · 7 comments
Closed

Global Config Form not reading live Configuration #20588

PhilETaylor opened this issue May 27, 2018 · 7 comments

Comments

@PhilETaylor
Copy link
Contributor

PhilETaylor commented May 27, 2018

Steps to reproduce the issue

Install Joomla 3.8.8
Go to admin -> Global Configuration -> as a test enable DEBUG = YES - then save,

LEAVE THE GLOBAL CONFIG PAGE OPEN (http://example.com/administrator/index.php?option=com_config)

Manually edit $debug = '0'; in /configuration.php, therefore setting debug to off

return to the Joomla admin and simply refresh the page (http://example.com/administrator/index.php?option=com_config)

Expected result

That the change on the file system is reflected in the interface

Actual result

Debug is still shown as on.
The config is loaded from the session, instead of from configuration.php

System information (as much as possible)

Joomla 3.8.8
Google Chrome

@dgrammatiko
Copy link
Contributor

Log out and log in again should update the values

@PhilETaylor

This comment was marked as abuse.

@dgrammatiko
Copy link
Contributor

I think it’s done this way for performance, but I guess the edit page should always fetch from the file, so I agree here

@dgrammatiko
Copy link
Contributor

dgrammatiko commented May 27, 2018

Flipping the arrays here

should do that, I do t know if there are bad effects doing it though

@ggppdk
Copy link
Contributor

ggppdk commented May 28, 2018

That merge order seems correct

administrator/components/com_config/controller/application/save.php

is different than other controllers it always adds data into session unlike all other controllers that only add them on

validation error
save error

Also it does not seem to clear them on successful save

@joomla-cms-bot
Copy link

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/20588

@ghost
Copy link

ghost commented May 28, 2018

closed as having Pull Request #20590

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants