-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protostar BC Break - Multi-Selects #20606
Comments
Pinging @okonomiyaki3000 |
@tonypartridge I need to know what |
I think something else may be to blame for what's happening here. If I replace Also, as long as they have the 'active' class, the code in |
Also, just FYI, if a |
@tonypartridge I just tried checking out older and older versions to see if I could determine where the change actually happened. I got as far as April 2017 and the behavior is the same as now (only one label shown as active at a time). I agree this doesn't make any sense for checkboxes but it seems it was always wrong. I suspect that, if it was working in a correct way for you before, it was some of your own code that was making that happen. Then, if #20224 did interfere with your code, it may be due to the fact that I switched to handling the click event through delegation instead of directly on the object where it occurs. This should not cause a problem in 99% of cases but it is a slightly different way of handling things so it's possible the problem is related. I would not like to go back to the old way though. Delegation is just a much better way of doing this. If I know more about any additional js running on your page, I can determine whether or not my guess is correct and maybe I can help you fix it. |
@okonomiyaki3000 if you revert your PR and instead use the original which is: Clear your cache obviously everything works again using the provided HTML. updateRepeatWarning() is just a notice handler with a simple alert message for our component. |
@tonypartridge Beez3? I thought this was about protostar? |
@tonypartridge could you clarify? Everything you've said up until now has been about Protostar but the link you've given is for Beez3. Also, as I said, I reverted the file (and all files) back as far as their state from April 2017 and got the same behavior. You probably need to give a full listing of all javascript (and maybe css) that is loaded on the page where this is working. |
@okonomiyaki3000 sorry you are right I've got the wrong PR.. the issue is protostar I'll look into it properly tomorrow and do a new issue if I get time. |
We had this code output for years:
In short it is a multi-day selector allowing the user to tick click the boxes. However, since PR: #20224 These now become single selects only allowing them to be selected once.
The text was updated successfully, but these errors were encountered: