Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Rename label for menu type #20726

Merged
merged 2 commits into from
Jun 13, 2018
Merged

[4.0] Rename label for menu type #20726

merged 2 commits into from
Jun 13, 2018

Conversation

chmst
Copy link
Contributor

@chmst chmst commented Jun 12, 2018

The label "menu type" is misleading. "type" is a general concept, here a unique name is required. It would be great if the description could be restored. At least the label should make clear that this name must be unique in the whole system.

Test: code inspection

@chmst chmst requested a review from brianteeman as a code owner June 12, 2018 12:12
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Jun 12, 2018
@@ -125,7 +125,7 @@ COM_MENUS_MENU_CONFIRM_DELETE="Are you sure you want to delete these menus? Conf
COM_MENUS_MENU_DETAILS="Menu Details"
COM_MENUS_MENU_EXPORT_BUTTON="Download as Preset"
COM_MENUS_MENU_ITEM_SAVE_SUCCESS="Menu item saved."
COM_MENUS_MENU_MENUTYPE_LABEL="Menu Type"
COM_MENUS_MENU_MENUTYPE_LABEL="Unique Menu Name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe "Unique Name"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or so. For me the "unique" is important.

@brianteeman
Copy link
Contributor

I never understood what this meant anyway

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2b7ef8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20726.

@chmst
Copy link
Contributor Author

chmst commented Jun 12, 2018

The whole handling is contrary of UX. This name is like a alias name - maybe better to use it like in content or elsewhere.

@brianteeman
Copy link
Contributor

I honestly have no idea why we have it or what it is for. I am guessing it is an internal name - if so then there is no need to expose it at all and it can just be autogenerated like the alias

@Wang-Yu-Chao
Copy link

Wang-Yu-Chao commented Jun 12, 2018

I have tested this item ✅ successfully on 2b7ef8d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20726.

The "Menu Type" label is replaced by "Unique Name" in the "Title" column.
image

@joomla-cms-bot joomla-cms-bot changed the title Rename label for menu type [4.0] Rename label for menu type Jun 12, 2018
@Quy
Copy link
Contributor

Quy commented Jun 12, 2018

The description in v3 refers it as system name. Would System Name be better?

@ghost
Copy link

ghost commented Jun 12, 2018

Ready to Commit after two successful tests.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 12, 2018
@brianteeman
Copy link
Contributor

@Quy thi is an improvement as the old name didnt imply it must be unique

@wilsonge wilsonge merged commit 11b938a into joomla:4.0-dev Jun 13, 2018
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 13, 2018
@zero-24 zero-24 added this to the Joomla 4.0 milestone Jun 14, 2018
@Quy
Copy link
Contributor

Quy commented Jul 1, 2018

The search box has tooltip Search in title and menu type. that needs to be updated.

@chmst
Copy link
Contributor Author

chmst commented Jul 1, 2018

I am not really happy with this solution.
For users ist is important to know that this is a unique name and that it is used only by the system.
The term "menutype" is used many times especially in com_associations, so it has a meaning for developers. Why not add again the description for users?
menutype-description

Then in #20787 (review) we could add the menutype like the alias in com_content/articles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Language Change This is for Translators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants