-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.0] Rename label for menu type #20726
Conversation
@@ -125,7 +125,7 @@ COM_MENUS_MENU_CONFIRM_DELETE="Are you sure you want to delete these menus? Conf | |||
COM_MENUS_MENU_DETAILS="Menu Details" | |||
COM_MENUS_MENU_EXPORT_BUTTON="Download as Preset" | |||
COM_MENUS_MENU_ITEM_SAVE_SUCCESS="Menu item saved." | |||
COM_MENUS_MENU_MENUTYPE_LABEL="Menu Type" | |||
COM_MENUS_MENU_MENUTYPE_LABEL="Unique Menu Name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or maybe "Unique Name"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or so. For me the "unique" is important.
I never understood what this meant anyway |
I have tested this item ✅ successfully on 2b7ef8d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20726. |
The whole handling is contrary of UX. This name is like a alias name - maybe better to use it like in content or elsewhere. |
I honestly have no idea why we have it or what it is for. I am guessing it is an internal name - if so then there is no need to expose it at all and it can just be autogenerated like the alias |
I have tested this item ✅ successfully on 2b7ef8d This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20726. The "Menu Type" label is replaced by "Unique Name" in the "Title" column. |
The description in v3 refers it as |
Ready to Commit after two successful tests. |
@Quy thi is an improvement as the old name didnt imply it must be unique |
The search box has tooltip |
I am not really happy with this solution. Then in #20787 (review) we could add the menutype like the alias in com_content/articles. |
The label "menu type" is misleading. "type" is a general concept, here a unique name is required. It would be great if the description could be restored. At least the label should make clear that this name must be unique in the whole system.
Test: code inspection