(UX) Add link to edit categories and show parent category #20740

coolcat-creations · 2018-06-13T17:36:59Z

Summary of Changes

This PR adds the Information to the parent category of the article before the category and offers a direct link to edit it.

Testing Instructions

Small change, big UX improvement
-> access the categories easier and faster
-> Some pages have similar named subcategories so its better to know the parent too

Please test coding style and everything, I did it how I thought it might work... thanks a lot!

brianteeman · 2018-06-13T17:47:58Z

Do we need to do something like just displaying the last x elements in the category tree if it is very long

brianteeman · 2018-06-13T17:54:57Z

There shouldnt be any queries in a template file.
For the template file please look your code and make sure that it is in a nested structure
You should probably update the featured articles view as well

Finally you are making all the categories a link - shouldnt the link be disabled if the user does not have permission to edit the category

coolcat-creations · 2018-06-13T18:07:46Z

it's just the parent of the last one... because i think it could indeed be very long

coolcat-creations · 2018-06-13T18:08:51Z

Finally you are making all the categories a link - shouldnt the link be disabled if the user does not have permission to edit the category

I thought i am doing that check - is it done wrong?

coolcat-creations · 2018-06-13T18:09:50Z

There shouldnt be any queries in a template file.

Can someone give me advise where and how to put the query in ?

brianteeman · 2018-06-13T18:20:48Z

I only had a chance to read the code and with the current formatting it's very hard to spot everything. Hence my earlier mistaken comments.

If you could do a quick update on just the code formatting it will make it easier

brianteeman · 2018-06-13T19:16:17Z

Do you think it would be helpful to have a visual indicator if the two categories shown are NOT at the root.

With PR

Suggestion

SharkyKZ · 2018-06-13T19:25:15Z

Query should be in articles model. See frontend articles model for example:
https://github.com/coolcat-creations/joomla-cms/blob/2334e0d888129ba2b4f42ec056b9cfe2086098ed/components/com_content/models/articles.php#L242-L244

SharkyKZ · 2018-06-13T20:02:24Z

For permission check to work you need to get permissions for each category. Currently, $canEdit and $canEditOwn variables hold permissions of article.

ROOT check should be performed against category ID as opposed to category title because it's possible to create a category titled ROOT.

coolcat-creations · 2018-06-14T08:43:15Z

Thank you both! I will work on it.

coolcat-creations · 2018-06-14T09:41:51Z

I put the query into the model, next steps will be the other improvements (acl and levelindicator) thanks again for your review!

Edit: levelidicator is done, Now my articletitle is messed up ;) will fix it.

coolcat-creations · 2018-06-14T11:41:49Z

I guess I am all set now, can you please review my code once more? Thank you!!!

SharkyKZ · 2018-06-14T12:16:41Z

The joins for category authors is unnecessary. The 4 category related blocks can be replaced with these 2:

// Join over the categories.
$query->select('c.title AS category_title, c.created_user_id as category_uid')
	->join('LEFT', '#__categories AS c ON c.id = a.catid');

// Join over the parent categories.
$query->select('parent.title AS parent_title, parent.id AS parent_id, parent.created_user_id AS parent_uid')
	->join('LEFT', '#__categories AS parent ON parent.id = c.parent_id');

This also removes some unnecessary selects, e.g. category ID is already selected as catid.

coolcat-creations · 2018-06-14T12:29:48Z

Thank you! Done :)

Quy · 2018-06-14T13:25:17Z

administrator/components/com_content/views/articles/tmpl/default.php

+									                href="<?php echo JRoute::_('index.php?option=com_categories&task=category.edit&id=' . $item->parent_category_id . '&extension=com_content'); ?>"
+									                title="<?php echo JText::_('JACTION_EDIT') . ' ' . JText::_('JCATEGORY'); ?>">
+
+											<?php endif ?>


Add semicolon

Quy · 2018-06-14T13:26:05Z

administrator/components/com_content/views/articles/tmpl/default.php

+
+											<?php endif ?>
+
+											<?php echo '' . $item->parent_category_title . ''; ?>


Remove ''. They are empty strings.

But there must be a space before the category?

I see now what you meant ;)

Quy · 2018-06-14T13:26:47Z

administrator/components/com_content/views/articles/tmpl/default.php

-									<?php echo JText::_('JCATEGORY') . ': ' . $this->escape($item->category_title); ?>
+									<?php echo JText::_('JCATEGORY') . ':' ?>
+
+										<?php if ($item->parent_category_id != '1')  : ?>


Remove extra space before :

Quy · 2018-06-14T13:29:34Z

Remove blank lines between lines 200-241.

Quy · 2018-06-14T13:32:13Z

administrator/components/com_content/views/articles/tmpl/default.php

@@ -190,7 +197,48 @@
 									<?php echo JText::sprintf('JGLOBAL_LIST_ALIAS', $this->escape($item->alias)); ?>
 								</span>
 								<div class="small">
-									<?php echo JText::_('JCATEGORY') . ': ' . $this->escape($item->category_title); ?>
+									<?php echo JText::_('JCATEGORY') . ':' ?>


Add semicolon

Quy · 2018-06-14T13:32:40Z

administrator/components/com_content/views/articles/tmpl/default.php

+
+											<?php if ($canEditParCat || $canEditOwnParCat) : ?>
+
+												<a  class="hasTooltip"


Remove extra space

Quy · 2018-06-14T13:33:23Z

administrator/components/com_content/views/articles/tmpl/default.php

+
+										<?php if ($canEditCat || $canEditOwnCat) : ?>
+
+											<a  class="hasTooltip"


Remove extra space

Quy · 2018-06-27T04:31:34Z

While it is convenient, how often are categories updated? Usually, they are set up and forget. This PR will add extra markup to the page that will probably not be used majority of the time.

coolcat-creations · 2018-06-27T07:23:26Z

@Quy Explaining Joomla to others and giving training brought me to that point. While you can jump to the articles from the Categories you can't access the Category from the Article. The intention is to enable the User to keep more care of the categories and als not to setup and forget. The extra Level brings sureness that they edit the right thing. Sometimes it's not clear just from one level. I think the markup is not blown very much.

Add Feature to Featured Articles Manager

uglyeoin · 2018-06-27T10:57:24Z

I have tested this item 🔴 unsuccessfully on ef35014

Sorry Elisa, this one failed. See this image for details:

https://www.dropbox.com/s/1nusc6o3iqp0ui9/elisa-categories-pull-request.png?dl=0

Looks like a small amendment. Let me know and I will test again.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20740.}

infograf768 · 2018-06-27T13:09:59Z

@uglyeoin
As i explained above, you cannot test this one by just setting en-GB to Rtl.
please install persian or Arabic and test again.

uglyeoin · 2018-06-27T13:11:19Z

@infograf768 sorry missed, that, will test again

uglyeoin · 2018-06-27T13:15:10Z

I have tested this item ✅ successfully on ef35014

Successfully tested in Persian

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20740.}

Quy · 2018-06-27T13:26:42Z

administrator/components/com_content/views/articles/tmpl/default.php

+											endif;
+										endif;
+
+										if ($this->document->direction == "ltr")


Should use isRtl() method to check.

@Quy
can't we use use both document->direction or
if (JFactory::getLanguage()->isRtl()) ?

infograf768 · 2018-06-27T14:13:56Z

I have tested this item ✅ successfully on ef35014

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20740.}

roland-d · 2018-06-27T14:17:05Z

@coolcat-creations Codestyle failures:

FILE: ...mla/joomla-cms/administrator/components/com_content/models/featured.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 111 | WARNING | Line exceeds 150 characters; contains 176 characters
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...mla/joomla-cms/administrator/components/com_content/models/articles.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 213 | WARNING | Line exceeds 150 characters; contains 176 characters
--------------------------------------------------------------------------------
UPGRADE TO PHP_CODESNIFFER 2.0 TO FIX ERRORS AUTOMATICALLY
--------------------------------------------------------------------------------

infograf768 · 2018-06-27T14:20:55Z

Well thought. Indeed drone is there to remind us.. :)

ghost · 2018-06-27T16:24:00Z

Ready to Commit after two successful tests.

infograf768 · 2018-06-27T18:24:15Z

rtc, after the cs is corrected. :)

infograf768 · 2018-06-28T05:16:05Z

@coolcat-creations
Can you correct the cs so that the PR is complete?

coolcat-creations · 2018-06-28T06:59:58Z

I corrected the lines, do I have to use the other rtl method too?

infograf768 · 2018-06-28T07:01:55Z

I corrected the lines, do I have to use the other rtl method too?

We use both methods in core. the most commonly used one is indeed JFactory::getLanguage()->isRtl()
You decide. 👍

coolcat-creations · 2018-06-28T07:32:47Z

Ok I used the more common method :)
Thank you all for testing and supporting, I learned a lot with this PR.

infograf768 · 2018-06-28T08:05:44Z

Milestoned to 3.9.0.
@mbabker

Add link to edit categories and show parent category

3a24f01

joomla-cms-bot added the PR-staging label Jun 13, 2018

coolcat-creations added 2 commits June 13, 2018 19:39

Check for ROOT category earlier

bb8823c

Fix wrong variable

2334e0d

Put the query into the model

573517a

coolcat-creations added 3 commits June 14, 2018 12:19

Check if category is the root or not

7c292f6

Check Permissions to edit category or parent category

6279a1d

Fix wrong article title

8ba8b60

Add suggested change for the queries

ed83bfa

Quy reviewed Jun 14, 2018

View reviewed changes

coolcat-creations added 2 commits June 27, 2018 10:29

Fix Code Style

a96dea2

Code Style

ef35014

Add Feature to Featured Articles Manager

Quy reviewed Jun 27, 2018

View reviewed changes

infograf768 added this to the Joomla 3.9.0 milestone Jun 27, 2018

joomla-cms-bot removed this from the Joomla 3.9.0 milestone Jun 27, 2018

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 27, 2018

Code Style

751272d

Use another method

27e4896

infograf768 added this to the Joomla 3.9.0 milestone Jun 28, 2018

mbabker changed the base branch from staging to 3.9-dev June 29, 2018 01:50

mbabker added PR-3.9-dev and removed PR-staging labels Jun 29, 2018

mbabker merged commit a443bbd into joomla:3.9-dev Jun 29, 2018

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jun 29, 2018


		<?php endif ?>

		<?php echo '' . $item->parent_category_title . ''; ?>


		<?php if ($canEditParCat \|\| $canEditOwnParCat) : ?>

		<a class="hasTooltip"


		<?php if ($canEditCat \|\| $canEditOwnCat) : ?>

		<a class="hasTooltip"

(UX) Add link to edit categories and show parent category #20740

(UX) Add link to edit categories and show parent category #20740

Conversation

coolcat-creations commented Jun 13, 2018 • edited by joomla-cms-bot

Summary of Changes

Testing Instructions

brianteeman commented Jun 13, 2018

brianteeman commented Jun 13, 2018

coolcat-creations commented Jun 13, 2018

coolcat-creations commented Jun 13, 2018

coolcat-creations commented Jun 13, 2018

brianteeman commented Jun 13, 2018

brianteeman commented Jun 13, 2018

With PR

Suggestion

SharkyKZ commented Jun 13, 2018

SharkyKZ commented Jun 13, 2018

coolcat-creations commented Jun 14, 2018

coolcat-creations commented Jun 14, 2018 • edited

coolcat-creations commented Jun 14, 2018

SharkyKZ commented Jun 14, 2018

coolcat-creations commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy commented Jun 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Quy commented Jun 27, 2018

coolcat-creations commented Jun 27, 2018 • edited

uglyeoin commented Jun 27, 2018

infograf768 commented Jun 27, 2018

uglyeoin commented Jun 27, 2018

uglyeoin commented Jun 27, 2018

Choose a reason for hiding this comment

infograf768 Jun 27, 2018 • edited

Choose a reason for hiding this comment

infograf768 commented Jun 27, 2018

roland-d commented Jun 27, 2018

infograf768 commented Jun 27, 2018

ghost commented Jun 27, 2018

infograf768 commented Jun 27, 2018 • edited

infograf768 commented Jun 28, 2018

coolcat-creations commented Jun 28, 2018

infograf768 commented Jun 28, 2018

coolcat-creations commented Jun 28, 2018

infograf768 commented Jun 28, 2018 • edited

coolcat-creations commented Jun 13, 2018 •

edited by joomla-cms-bot

coolcat-creations commented Jun 14, 2018 •

edited

coolcat-creations commented Jun 27, 2018 •

edited

infograf768 Jun 27, 2018 •

edited

infograf768 commented Jun 27, 2018 •

edited

infograf768 commented Jun 28, 2018 •

edited