Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0][RFC] Hardcode Some Modules Into Admin Template #20801

Closed
mbabker opened this issue Jun 20, 2018 · 10 comments
Closed

[4.0][RFC] Hardcode Some Modules Into Admin Template #20801

mbabker opened this issue Jun 20, 2018 · 10 comments
Labels

Comments

@mbabker
Copy link
Contributor

mbabker commented Jun 20, 2018

Adding docs noting how a user upgrading their sites to 3.9 would add the new modules to the admin control panel got me thinking, there are several modules which if a user unpublished would really make use of the backend pretty difficult. Primarily this is the Admin Menu, Title, and Toolbar modules, and to a lesser extent the Admin Submenu module (this one really impacts Hathor more than Isis, and is already gone in 4.0). Note we already go through some extra steps to ensure there's a login module for use on the backend in case someone manages to unpublish this one.

We should probably not have these as configurable modules in 4.0. My suggestion would be something similar to the hardcoded mod_feed instance in the com_postinstall messages view.

@brianteeman
Copy link
Contributor

I understand what you are talking about and almost agree. The site builder might want to replace those modules with their own variants or perhaps an alternative admin template uses its own modules for this

@mbabker
Copy link
Contributor Author

mbabker commented Jun 20, 2018

Yeah, those are both legitimate concerns. Dropping the title module just creates some visual problems, so it's less of an issue, but dropping the menu and toolbar can make your backend unusable. So right now I kind of lean toward the "these are critical capabilities and maybe that means we should sacrifice a little flexibility out-of-the-box" side of the line. Alternative templates would be able to use modules as the case is now, hardcode their own module implementations, or whatever the case may be still.

@ciar4n
Copy link
Contributor

ciar4n commented Jun 20, 2018

Is there any argument for having that if the module exists then the hardcoded element is replaced by the module position?

@brianteeman
Copy link
Contributor

You also forget that with the current module system a site owner can move these "critical" modules to different positions.

@brianteeman
Copy link
Contributor

In conclusion it is either a template with modules etc or a complete application. I don't believe you can have both . My 10c

@mbabker
Copy link
Contributor Author

mbabker commented Jun 20, 2018

This is one of those times where I really feel like having capabilities exposed in the UI can let a user shoot themselves in the foot way too easily (same argument can be made for authentication plugins). Having a truly modular backend is not something we designed Isis for, and I guarantee the 4.0 work won't be either. Sure, some stuff can be moved around and things display OK (move the toolbar to the title position, it works but you've still got the sticky navbar that's now empty), but there's also some magic in Isis at least that means if you move some things out of position they don't display right at all (i.e. change the user status module to the footer position instead of status).

So I don't think it'd be an extremely terrible thing to hardcode some stuff direct into the template, unless we're going to commit to a properly modular admin template.

@ciar4n
Copy link
Contributor

ciar4n commented Jun 20, 2018

All things considered I think my preference would be to also hardcode these elements. It is certainly the easier option. The alternative involves a lot more considerations for largely edge cases.

@brianteeman
Copy link
Contributor

So hard code all the modules that are part of the ui. ie everything that is not a dashboard item.

@dgrammatiko
Copy link
Contributor

@mbabker I've already started something for this: https://github.com/joomla/40-backend-template/compare/master...dgrammatiko:html5-please?expand=1

Obviously for the same reasons that you mentioned above I totally agree...

@brianteeman
Copy link
Contributor

Seems that we already have modules hard coded into components now.

@mbabker mbabker closed this as completed Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants