Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Enabling plg_content_finder plugin by default #20904

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jun 27, 2018

This PR just enables the content finder plugin by default on new installations. This is a step towards making com_finder the default search system in Joomla. This needs a decision by the higher-ups if we are going to go in that direction. Otherwise this just requires a code review.

@infograf768
Copy link
Member

OK for me. But it does not mean I agree with removing com_search... 😄

@brianteeman
Copy link
Contributor

That makes no sense. If com_search was to remain then this should not be enabled by default.

@infograf768
Copy link
Member

infograf768 commented Jun 28, 2018

That makes no sense. If com_search was to remain then this should not be enabled by default.

Except if we keep com_search as a choice for admins and make new installation sample data default to com_finder.

@wilsonge
Copy link
Contributor

wilsonge commented Jul 1, 2018

The higher up definitely wants to make finder at least the default search component instead of search. I wouldn't be comfortable remove search without consulting with rest of production team tho.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on eae1f79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20904.

1 similar comment
@Quy
Copy link
Contributor

Quy commented Jul 25, 2018

I have tested this item ✅ successfully on eae1f79


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20904.

@Quy
Copy link
Contributor

Quy commented Jul 25, 2018

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20904.

@joomla-cms-bot joomla-cms-bot added RTC This Pull Request is Ready To Commit and removed PR-4.0-dev labels Jul 25, 2018
@wilsonge wilsonge merged commit 3cd686c into joomla:4.0-dev Sep 7, 2018
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 7, 2018
@joomla-cms-bot joomla-cms-bot added PR-4.0-dev and removed RTC This Pull Request is Ready To Commit labels Sep 7, 2018
brianteeman pushed a commit to brianteeman/joomla-cms that referenced this pull request Sep 8, 2018
@Hackwar Hackwar deleted the j4finder_enabled branch April 27, 2019 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants